Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CATROID-1394 Export projects to Downloads-directory #4504

Merged
merged 1 commit into from
May 17, 2022

Conversation

Walcho1125
Copy link
Contributor

@Walcho1125 Walcho1125 commented Apr 12, 2022

Please enter a short description of your pull request and add a reference to the Jira ticket.
Export projects to Downloads-directory
https://jira.catrob.at/browse/CATROID-1394

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

Copy link
Contributor

@Tamdav Tamdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@wslany wslany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not create a "Catrobat" subfolder in the "Download" folder. Instead, directly store the file in the "Download" folder at the latter's top level, without a subfolder. Thus, for ProjectOptionsTest.java also only delete the exported project, not the folder itself.

@Walcho1125 Walcho1125 force-pushed the CATROID-1394 branch 2 times, most recently from 28e717c to 62a89be Compare April 19, 2022 09:09
Copy link
Contributor

@Tamdav Tamdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@wslany wslany merged commit c29142f into Catrobat:develop May 17, 2022
@wslany
Copy link
Member

wslany commented May 17, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants