Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CATROID-1393 Remove redundant code of directory-import #4506

Merged
merged 1 commit into from
Aug 3, 2022
Merged

CATROID-1393 Remove redundant code of directory-import #4506

merged 1 commit into from
Aug 3, 2022

Conversation

Walcho1125
Copy link
Contributor

@Walcho1125 Walcho1125 commented Apr 14, 2022 •
edited by bengaal
Loading

Please enter a short description of your pull request and add a reference to the Jira ticket.
https://jira.catrob.at/browse/CATROID-1393
Remove redundant code of directory-import

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@Walcho1125 Walcho1125 force-pushed the CATROID-1393 branch 6 times, most recently from ab3eef5 to d75b690 Compare May 29, 2022 16:15
bengaal
bengaal approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@bengaal bengaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

catroid/src/main/java/org/catrobat/catroid/ui/filepicker/ListProjectFilesTask.kt Outdated Show resolved Hide resolved
catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/fragment/ProjectListFragment.kt Outdated Show resolved Hide resolved
@Walcho1125 Walcho1125 force-pushed the CATROID-1393 branch 2 times, most recently from 7ec882c to b29899a Compare July 19, 2022 12:38
@Walcho1125 Walcho1125 force-pushed the CATROID-1393 branch 2 times, most recently from 671ac44 to 80d8a13 Compare July 20, 2022 15:14
@juliajulie95 juliajulie95 merged commit 59b6366 into Catrobat:develop Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliajulie95 juliajulie95 juliajulie95 approved these changes

@bengaal bengaal bengaal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Walcho1125 @bengaal @juliajulie95