Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CATROID-1413 Fix GMS Speech Recognition on Huawei Phones #4520

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

bigsmallpp
Copy link
Contributor

@bigsmallpp bigsmallpp commented Apr 29, 2022

Fixed GMS for the StartListeningBrick on Huawei phones.
Since GMS for the AskSpeechBrick was already working, the same concept is now also used for the StartListeningBrick.
Since Huawei phones should be using HMS anyways once it's implemented, the applied fix should be redundant as soon as this is the case.
Ticket

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

Fixed GMS for the StartListeningBrick on Huawei phones.
The applied fix should be removed as soon as HMS is properly integrated and working.
@ratschillerp ratschillerp merged commit f1d359a into Catrobat:develop Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants