Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CATROID-1399 Bluetooth export (.catrobat, .dst) #4524

Closed
wants to merge 1 commit into from
Closed

CATROID-1399 Bluetooth export (.catrobat, .dst) #4524

wants to merge 1 commit into from

Conversation

StofflR
Copy link
Contributor

@StofflR StofflR commented May 3, 2022

MIME-Type "application/octet-stream" is by default not supported to Bluetooth sharing. (Usually depends on android version and OEM implementation)
Changing the MIME Type to "text/*" enables the option to share via Bluetooth.
Note: "application/octet-stream" is the correct MIME Type for .dst, but disables the option to share the files via Bluetooth on some devices.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

CATROID-1399 Bluetooth export (.catrobat, .dst)
2b4b720 
- MIME-Type "application/octet-stream" sharing via only supported by some android versions / smartphone brands
- MIME Type "text/*" is not restricted by default in bluetooth
- MIME-Type "text/*" enables bluetooth sharing option on all devices -> no dependency on android version / smartphone brand
Note: "application/octet-stream" is the correct filetype of .dst files though
@juliajulie95 juliajulie95 mentioned this pull request May 9, 2022
Merged
14 tasks
@juliajulie95
Copy link
Contributor

Moved code to new PR + fixed a failing test
#4540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StofflR @juliajulie95