Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CATROID-1367 Add single undo functionality in datalist #4627

Merged
merged 6 commits into from
May 30, 2023
Merged

CATROID-1367 Add single undo functionality in datalist #4627

merged 6 commits into from
May 30, 2023

Conversation

sebastiangollob
Copy link
Member

@sebastiangollob sebastiangollob commented Sep 18, 2022 •
edited
Loading

Added single undo functionality in datalist. Allows to undo rename, delete and edit of variables in the datalist.

https://jira.catrob.at/browse/CATROID-1367

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@sebastiangollob sebastiangollob force-pushed the CATROID-1367 branch 2 times, most recently from 1cf68a3 to d7cb68c Compare September 29, 2022 15:14
bengaal
bengaal approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@bengaal bengaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you! :)

@sebastiangollob sebastiangollob force-pushed the CATROID-1367 branch 3 times, most recently from 250e891 to 6a4a648 Compare November 5, 2022 17:35
sebastiangollob and others added 6 commits November 5, 2022 18:43
@sebastiangollob
CATROID-1367 Add single undo functionality in datalist
d98ca42
@dorianpercic @sebastiangollob
CATROID-1484 Fix additional starting of new intro dialog onResume of …
96611c4 
…FormulaEditorFragment
@mseiser @wslany
@juliajulie95 @sebastiangollob
Fix Removing Request Install Permissions (Catrobat#4645)
10d79e5 
REQUEST_INSTALL_PACKAGES was used to install standalone APKs. This feature has been disabled due to security concerns, so REQUEST_INSTALL_PACKAGES is not needed anymore.

However, the The REQUEST_INSTALL_PACKAGES permission removal apparently was then ignored. The permission was no longer in our manifest, but if you looked at the apk using Android Studio apk analyzer, it still was there. Apparently it is added in the manifest merge step because of some library we have in it. Figuring out which one it is is not so easy, so we now explicitly state in the manifest that the permission must not be included.

Co-authored-by: Wolfgang Slany <1747888+wslany@users.noreply.github.com>
Co-authored-by: Julia <j.herold@student.tugraz.at>
@mseiser @sebastiangollob
CATROID-1493 Fix unwanted delete of original
f89a4ef 
Fixes bug that deletes file when deleting imported object
@friendo97 @sebastiangollob
CATROID-1429 Remove keyboard when no input is possible in upload
fca6fa8
@mseiser @sebastiangollob
CATROID-1498 fix option icons in main menu
960bf25
@mseiser mseiser merged commit 8fa219a into Catrobat:develop May 30, 2023
@mseiser mseiser mentioned this pull request Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mseiser mseiser mseiser approved these changes

@bengaal bengaal bengaal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sebastiangollob @bengaal @mseiser @dorianpercic @friendo97