Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CATROID-1494 Check checkbox when clicking on a fragment #4656

Merged
merged 1 commit into from
Jan 25, 2023
Merged

CATROID-1494 Check checkbox when clicking on a fragment #4656

merged 1 commit into from
Jan 25, 2023

Conversation

l-ilma
Copy link
Contributor

@l-ilma l-ilma commented Nov 17, 2022 •
edited
Loading

Enable checkbox selection when clicking on the desired fragment -> not just on the checkbox itself.
https://jira.catrob.at/browse/CATROID-1494

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@l-ilma l-ilma force-pushed the CATROID-1494 branch 3 times, most recently from b59e9a1 to c8fe16e Compare November 23, 2022 20:16
@l-ilma l-ilma marked this pull request as ready for review November 23, 2022 20:17
@l-ilma l-ilma requested a review from mseiser November 23, 2022 20:55
mseiser
mseiser requested changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@mseiser mseiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor changes: please add test in DeleteLookDialog test, and fix static analysis warnings 😸

@l-ilma
Copy link
Contributor Author

l-ilma commented Nov 30, 2022

just some minor changes: please add test in DeleteLookDialog test, and fix static analysis warnings 😸

Thanks for noticing! I fixed it now, can you check it one more time please? ☺️

@l-ilma l-ilma requested a review from mseiser November 30, 2022 12:59
mseiser
mseiser approved these changes Dec 25, 2022
View reviewed changes
Copy link
Contributor

@mseiser mseiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you 😺

Walcho1125
Walcho1125 approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@Walcho1125 Walcho1125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Walcho1125 Walcho1125 merged commit fccbdca into Catrobat:develop Jan 25, 2023
UlrichLa added a commit to UlrichLa/Catroid that referenced this pull request Feb 12, 2023
@UlrichLa
Squashed commit of the following:
83bf190 
commit 51621e6
Author: Ulrich Lackner <ulrich.lackner@student.tugraz.at>
Date:   Mon Jan 30 20:03:47 2023 +0100

    Further improvements 2

commit 250f00d
Author: Ulrich Lackner <ulrich.lackner@student.tugraz.at>
Date:   Mon Jan 30 18:17:53 2023 +0100

    Further improvements

commit 9226cf5
Author: Ulrich Lackner <ulrich.lackner@student.tugraz.at>
Date:   Mon Jan 30 17:56:22 2023 +0100

    Sprite changed Mulitmap to HashMap.

commit 01f38fb
Author: Ulrich Lackner <ulrich.lackner@student.tugraz.at>
Date:   Mon Jan 30 17:45:25 2023 +0100

    Group.setTransform set to false

    To improve performance but verify if it does not have side effects.

commit 5c388aa
Author: Ulrich Lackner <ulrich.lackner@student.tugraz.at>
Date:   Mon Jan 30 17:40:16 2023 +0100

    Seperate Sprite name and clone name

    Improves performance

commit fccbdca
Merge: 15b1d13 112262f
Author: Oskar W <37344900+Walcho1125@users.noreply.github.com>
Date:   Wed Jan 25 14:32:35 2023 +0100

    Merge pull request Catrobat#4656 from l-ilma/CATROID-1494

    CATROID-1494 Check checkbox when clicking on a fragment

commit 15b1d13
Merge: fd58d68 6cf62dd
Author: Oskar W <37344900+Walcho1125@users.noreply.github.com>
Date:   Mon Jan 16 14:50:21 2023 +0100

    Merge pull request Catrobat#4655 from friendo97/CATROID-1468

    CATROID-1468 DeleteLookBrickTest failing

commit 6cf62dd
Author: Florian Lassnig <florian.lassnig@student.tugraz.at>
Date:   Wed Nov 9 18:38:07 2022 +0100

    CATROID-1468 DeleteLookBrickTest failing

commit fd58d68
Merge: 909e73a 6052db6
Author: Robert Leiner <37551961+Rawbat@users.noreply.github.com>
Date:   Tue Dec 6 17:31:43 2022 +0100

    Merge pull request Catrobat#4612 from sebastiangollob/CATROID-1480

    CATROID-1480 Add CLT for repeat bricks

commit 112262f
Author: Ilma Lušija <ilma.lusija@student.tugraz.at>
Date:   Thu Nov 17 20:48:35 2022 +0100

    CATROID-1494 Check checkbox when clicking on a fragment

commit 6052db6
Author: Sebastian Gollob <sebastiangollob@gmail.com>
Date:   Tue Aug 16 23:57:02 2022 +0200

    CATROID-1480 Add CLT for repeat bricks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mseiser mseiser mseiser approved these changes

@Walcho1125 Walcho1125 Walcho1125 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@l-ilma @Walcho1125 @mseiser