Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CATROID-IDE-11 Adding User Defined Bricks Crashes App #4673

Merged
merged 1 commit into from
Jul 25, 2023
Merged

CATROID-IDE-11 Adding User Defined Bricks Crashes App #4673

merged 1 commit into from
Jul 25, 2023

Conversation

l-ilma
Copy link
Contributor

@l-ilma l-ilma commented Jan 27, 2023

Bugfix: adding user defined brick crashes the app.
https://jira.catrob.at/browse/IDE-11

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@l-ilma l-ilma marked this pull request as ready for review January 27, 2023 17:25
mseiser
mseiser approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@mseiser mseiser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍 fixxes org.catrobat.catroid.catrobattestrunner.CatrobatTestRunner.run[catrobatTests/bricks/control - testFastUserDefinedBrick.catrobat]

@dorianpercic dorianpercic merged commit 56e8dcb into Catrobat:develop Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moberer moberer moberer approved these changes

@mseiser mseiser mseiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@l-ilma @mseiser @moberer @dorianpercic