Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CATROID-1462 Change variable by "" brick does not work #4685

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

Rawbat
Copy link
Contributor

@Rawbat Rawbat commented Feb 14, 2023

Loop bricks now actually change their control variable instead of continually
setting it with calculated values. This allows for other change variable operations
inside the loop to have an effect.
This however furthers the possibility to create infinite loops and the resulting
value of the control variable after the loop is not as easily predictable when using
another change value operation inside the loop.

https://jira.catrob.at/browse/CATROID-1462

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@Rawbat Rawbat force-pushed the CATROID-1462 branch 3 times, most recently from 51e27b8 to 78fa4cc Compare February 21, 2023 16:35
 Loop bricks now actually change their control variable instead of continually
 setting it with calculated values. This allows for other change variable operations
 inside the loop to have an effect.
 This however furthers the possibility to create infinite loops and the resulting
 value of the control variable after the loop is not as easily predictable when using
 another change value operation inside the loop.
Copy link
Contributor

@Hugoluk Hugoluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Added and adjusted test are also fine.
The test "ForVariableFromToActionTest" seems to through when running all unit tests, but fails when running alone. A ticket for this flaky test was created (CATROID-1559).

Copy link
Contributor

@JayTropper JayTropper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything fine for me!

@JayTropper JayTropper merged commit 9d29597 into Catrobat:develop Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants