Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CATROID-1069 REFACTOR CloneAction to Kotlin #4703

Merged
merged 1 commit into from
Mar 8, 2023
Merged

CATROID-1069 REFACTOR CloneAction to Kotlin #4703

merged 1 commit into from
Mar 8, 2023

Conversation

Aayush2111
Copy link
Contributor

@Aayush2111 Aayush2111 commented Feb 24, 2023 •
edited
Loading

Jira ticket: https://jira.catrob.at/browse/CATROID-1069

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@Aayush2111 Aayush2111 force-pushed the CATROID-1069 branch 2 times, most recently from a9bf7d5 to 974ca6d Compare February 24, 2023 08:57
@Aayush2111
Copy link
Contributor Author

@ThorstenBandel @sebastiangollob
Please review the changes and provide any feedback that you may have.
Thank you! :)

sebastiangollob
sebastiangollob previously requested changes Feb 25, 2023
View reviewed changes
Copy link
Member

@sebastiangollob sebastiangollob left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also ensure that the files have up-to-date copyright notice using the builtin format feature of Android Studio (e.g. CloneAction.kt is missing the 2023 in the copyright notice).

See also #4693

@Aayush2111 Aayush2111 force-pushed the CATROID-1069 branch 2 times, most recently from 444c54a to 8ee7892 Compare February 25, 2023 13:38
@Aayush2111
Copy link
Contributor Author

Please also ensure that the files have up-to-date copyright notice using the builtin format feature of Android Studio (e.g. CloneAction.kt is missing the 2023 in the copyright notice).

See also #4693

Updated on both
Thanks! :)

@Aayush2111 Aayush2111 force-pushed the CATROID-1069 branch 2 times, most recently from bc05518 to 35f1ce8 Compare February 25, 2023 15:56
mseiser
mseiser approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@mseiser mseiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@mseiser mseiser dismissed sebastiangollob’s stale review March 8, 2023 15:21

request has been implemented

sebastiangollob
sebastiangollob approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@sebastiangollob sebastiangollob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@mseiser mseiser merged commit 8f001bb into Catrobat:develop Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mseiser mseiser mseiser approved these changes

@sebastiangollob sebastiangollob sebastiangollob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aayush2111 @sebastiangollob @mseiser