Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDE-179 Add a catrobat language test for the ForEach brick #4808

Merged
merged 1 commit into from
Jul 25, 2023
Merged

IDE-179 Add a catrobat language test for the ForEach brick #4808

merged 1 commit into from
Jul 25, 2023

Conversation

moberer
Copy link
Contributor

@moberer moberer commented Jun 15, 2023 •
edited
Loading

Jira Ticket

Add a catrobat language test for the ForEach brick.

The test checks for

  • empty lists
  • lists of different length
  • iteration order
  • correct amount of loops

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@moberer
Copy link
Contributor Author

moberer commented Jun 18, 2023

Note: Failing TC also fails on "develop" branch.

@dorianpercic dorianpercic self-requested a review June 22, 2023 09:27
dorianpercic
dorianpercic approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@dorianpercic dorianpercic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@moberer moberer requested a review from becothas July 4, 2023 08:02
IDE-179 Add a catrobat language test for the ForEach brick
34573cf 
Added checks for
- empty lists
- lists of different length
- iteration order
- correct amount of loops
@dorianpercic dorianpercic merged commit 775d6af into Catrobat:develop Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorianpercic dorianpercic dorianpercic approved these changes

@becothas becothas becothas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moberer @becothas @dorianpercic