Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CATROID-1402 Create more Catblocks Test in Catroid #4809

Merged
merged 1 commit into from
Aug 5, 2023
Merged

CATROID-1402 Create more Catblocks Test in Catroid #4809

merged 1 commit into from
Aug 5, 2023

Conversation

MichaelFlucher
Copy link
Member

@MichaelFlucher MichaelFlucher commented Jun 16, 2023 •
edited
Loading

https://jira.catrob.at/browse/CATROID-1402
Add additional Unit Tests for Catblocks, now not based on UIDevice anymore, but with Javascript Events.
New Version of PR #4628

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@MichaelFlucher MichaelFlucher force-pushed the CATROID-1402-PR-After-Rewrite branch 8 times, most recently from 7990350 to 9b8baaa Compare June 19, 2023 17:44
bprattes
bprattes approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@bprattes bprattes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelFlucher MichaelFlucher force-pushed the CATROID-1402-PR-After-Rewrite branch from 9b8baaa to 6fac92a Compare July 17, 2023 21:16
@MichaelFlucher
Copy link
Member Author

@moberer I moved the JS code to an own file within assets/catblocks

bprattes
bprattes approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@bprattes bprattes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelFlucher MichaelFlucher merged commit ab977c1 into Catrobat:develop Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moberer moberer moberer approved these changes

@bprattes bprattes bprattes approved these changes

Assignees

@MichaelFlucher MichaelFlucher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelFlucher @bprattes @moberer