Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDE-176 Rework formula editor #4827

Conversation

becothas
Copy link
Contributor

@becothas becothas commented Jul 13, 2023

  • Change the design to look like material 3
  • Add buttons for copy and paste
  • Remove old copy & paste popup
    IDE-176

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@becothas becothas force-pushed the feature/IDE-176_Rework_formula_editor branch 7 times, most recently from 611a87f to f0f5729 Compare July 14, 2023 10:12
@moberer

This comment was marked as resolved.

@moberer

This comment was marked as resolved.

@moberer
Copy link
Contributor

moberer commented Jul 17, 2023

The behaviour that the entire formula is copied when nothing is selected is not intended to be implemented here already, right? - But "linking up" the buttons was already done, from what I can see in the code.

If so, we should probably reformulate https://jira.catrob.at/browse/IDE-177 to account for this.

@becothas becothas force-pushed the feature/IDE-176_Rework_formula_editor branch from f0f5729 to 4ed94ae Compare July 17, 2023 08:59
@becothas

This comment was marked as resolved.

@becothas becothas force-pushed the feature/IDE-176_Rework_formula_editor branch from 91a0f38 to 630af7a Compare July 25, 2023 17:45
@becothas becothas force-pushed the feature/IDE-176_Rework_formula_editor branch 2 times, most recently from 036c6e3 to bd15502 Compare August 8, 2023 13:00
@dorianpercic dorianpercic self-requested a review October 4, 2023 10:29
@dorianpercic dorianpercic force-pushed the feature/IDE-176_Rework_formula_editor branch 2 times, most recently from 1f94550 to 5ffd49a Compare October 5, 2023 10:42
Copy link
Contributor

@dorianpercic dorianpercic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dorianpercic dorianpercic force-pushed the feature/IDE-176_Rework_formula_editor branch from 5ffd49a to 5f34e9a Compare October 5, 2023 10:49
@dorianpercic dorianpercic merged commit af8dc0e into Catrobat:develop Oct 5, 2023
@becothas becothas deleted the feature/IDE-176_Rework_formula_editor branch October 8, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants