-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IDE-176 Rework formula editor #4827
IDE-176 Rework formula editor #4827
Conversation
611a87f
to
f0f5729
Compare
This comment was marked as resolved.
This comment was marked as resolved.
catroid/src/main/java/org/catrobat/catroid/ui/FormulaEditorCopyPasteController.kt
Outdated
Show resolved
Hide resolved
catroid/src/main/java/org/catrobat/catroid/ui/FormulaEditorCopyPasteController.kt
Outdated
Show resolved
Hide resolved
catroid/src/main/java/org/catrobat/catroid/ui/FormulaEditorCopyPasteController.kt
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
The behaviour that the entire formula is copied when nothing is selected is not intended to be implemented here already, right? - But "linking up" the buttons was already done, from what I can see in the code. If so, we should probably reformulate https://jira.catrob.at/browse/IDE-177 to account for this. |
f0f5729
to
4ed94ae
Compare
This comment was marked as resolved.
This comment was marked as resolved.
catroid/src/main/res/drawable/ic_formula_editor_content_copy.xml
Outdated
Show resolved
Hide resolved
91a0f38
to
630af7a
Compare
036c6e3
to
bd15502
Compare
1f94550
to
5ffd49a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
5ffd49a
to
5f34e9a
Compare
IDE-176
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.