IDE-130 Fix spriteEqualBackgroundTest #4847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorianpercic
force-pushed
the
IDE-130
branch
2 times, most recently
from
5d5ae88 to
37a2601
Compare
moberer
reviewed
Jul 31, 2023
catroid/src/androidTest/java/org/catrobat/catroid/test/content/sprite/SpriteTest.java
Outdated
Show resolved
Hide resolved
dorianpercic
force-pushed
the
IDE-130
branch
2 times, most recently
from
286b9b1 to
3240cb1
Compare
|
This branch has conflicts that must be resolved but other than that looks good to me! |
dorianpercic
force-pushed
the
IDE-130
branch
from
3240cb1 to
b01515e
Compare
Resolved! |
becothas
reviewed
Nov 23, 2023
catroid/src/androidTest/java/org/catrobat/catroid/test/content/sprite/SpriteTest.java
Outdated
Show resolved
Hide resolved
catroid/src/androidTest/java/org/catrobat/catroid/test/content/sprite/SpriteTest.java
Outdated
Show resolved
Hide resolved
Remove spriteEqualBackgroundTest as an uiespresso test, instead implement as an Unit Test.
dorianpercic
force-pushed
the
IDE-130
branch
from
b01515e to
c7f7b54
Compare
becothas
pushed a commit
that referenced
this pull request
Jan 12, 2024
Remove spriteEqualBackgroundTest as an uiespresso test, instead implement as an Unit Test.
ratschillerp
added a commit
that referenced
this pull request
Oct 30, 2024
* CATROID-988 Bug fixed, where object name and background can be equal * New Crowdin translations by Github Action * CATROID-1384 Continuously update parameter field in formula editor * Version increase for v1.1.1 * CATROID-554 Data overview in formula editor becomes unusable * Added command to have Piantroid build with Catroid working again * New Crowdin translations by Github Action * [Maintenance] Upgrade to Paintroid v2.8.3 * Version increase for v1.1.2 * CATROID-1418 update Catblocks to 1.4.0 and enable release * CATROID-1422 Reverse "Keep original aspect ratio" project option (#13) * Reverse "Keep original aspect ratio" option * "Keep original aspect ratio" was reversed * CATROID-1399 Bluetooth export (.catrobat, .dst) * New Crowdin translations by Github Action * CATROID-1394 Export projects to Downloads-directory * CATROID-1420 Looks in scenes becomes corrupted after renaming the scene * CATROID-1416 "Find/search" in Scripts should ignore trailing spaces * CATROID-1419 [HIGH-PRIORITY] Crash with formulas in parameter fields of "Become focus point with x y flexibility" * CATROID-1286 Improve constants names * Fix filename issues * CATROID-1392 CLT for look name and number of looks * CATROID-1425 Fix Performance of BrickSearch * [Maintenance] Upgrade to Paintroid v2.9.1 (#4575) * CATROID-1057 REFACTOR Look/PhysicsLook Extracted PhysicsObjectStateHandler from PhysicsLook. Reduce Code Duplication and Magic Number Usage, and general Code Cleanup in PhysicsLook * CATROID-1424 'Start sound PULLDOWN at XX seconds' brick Created layout for brick. Added fucntionality to brick. Added JUnit tests. Fixed Warnings. Implemented requested changes from pull request. * CATROID-1196 Brick Search History * DEVOPS-375 MAINTENANCE Add boolean param. for outgoingNetworkCalls, add. stage for outgoing Network call test in Jenkinsfile, add change docker file to catrobat-android stable * CATROID-1417 Bug fixed where visual placement is skipped * CATROID-1168 Refactor UserDefinedBrickListFragment and PrototypeBrickAdapter to kotlin * CATROID-1163 Add Icons to Menus (#4275) Creates new ArrayAdapter for AlertDialogs to view icons and adds icons to all option and pop-up menus https://jira.catrob.at/browse/CATROID-1163 * [MAINTENANCE] Change copyright in every file * CATROID-1121 Refactor MainMenuActivity and related files to Kotlin * CATROID-1393 Remove redundant code of directory-import * Increase Catrobat language version * CATROID-810 Fix some linting errors * [HOTFIX] Resolve Static Analysis Warning * New Crowdin translations by Github Action * Catroid-1467 Checkboxes for deleting variables missing * CATROID-1469 Test: testCloneValues failing Fixed by mocking the problematic method "setFixedRotation" in the physics object. This required it to make the method public. * CATROID-1471 Test: testPickColorCancel fails Fixed by removing a wrong and unnecessary condition in the test * CATROID-1470 Test: testPhiroLightRGBPickColorCancel fails Fixed by removing wrong and unnecessary condition in the test * CATROID-1480 Add CLT for repeat bricks * DEVOPS-694 fixed DockerParameters * CATROID-1465 Add sprite from library gets downloaded to current project * CATROID-1078 Add new CLTs for the set transparency brick * CATROID-1484 Fix additional starting of new intro dialog onResume of FormulaEditorFragment * CATROID-1490 Fix Static Analysis by adding newline * CATROID-1140 Refactor adapter and related files of ScriptFragment to kotlin * Fix Removing Request Install Permissions (#4645) REQUEST_INSTALL_PACKAGES was used to install standalone APKs. This feature has been disabled due to security concerns, so REQUEST_INSTALL_PACKAGES is not needed anymore. However, the The REQUEST_INSTALL_PACKAGES permission removal apparently was then ignored. The permission was no longer in our manifest, but if you looked at the apk using Android Studio apk analyzer, it still was there. Apparently it is added in the manifest merge step because of some library we have in it. Figuring out which one it is is not so easy, so we now explicitly state in the manifest that the permission must not be included. Co-authored-by: Wolfgang Slany <1747888+wslany@users.noreply.github.com> Co-authored-by: Julia <j.herold@student.tugraz.at> * CATROID-1474 Update huawei ml libraries * CATROID-1429 Remove keyboard when no input is possible in upload * CATROID-1493 Fix unwanted delete of original Fixes bug that deletes file when deleting imported object * CATROID-1202 implement add brick functionality in Catblocks * CATROID-1498 fix option icons in main menu * CATROID-1367 Add single undo functionality in datalist * CATROID-1484 Fix additional starting of new intro dialog onResume of FormulaEditorFragment * Fix Removing Request Install Permissions (#4645) REQUEST_INSTALL_PACKAGES was used to install standalone APKs. This feature has been disabled due to security concerns, so REQUEST_INSTALL_PACKAGES is not needed anymore. However, the The REQUEST_INSTALL_PACKAGES permission removal apparently was then ignored. The permission was no longer in our manifest, but if you looked at the apk using Android Studio apk analyzer, it still was there. Apparently it is added in the manifest merge step because of some library we have in it. Figuring out which one it is is not so easy, so we now explicitly state in the manifest that the permission must not be included. Co-authored-by: Wolfgang Slany <1747888+wslany@users.noreply.github.com> Co-authored-by: Julia <j.herold@student.tugraz.at> * CATROID-1493 Fix unwanted delete of original Fixes bug that deletes file when deleting imported object * CATROID-1429 Remove keyboard when no input is possible in upload * CATROID-1498 fix option icons in main menu * CATROID-1494 Check checkbox when clicking on a fragment * CATROID-1468 DeleteLookBrickTest failing * CATROID-1371 REFACTOR SetBrightnessAction to Kotlin * [MAINTENANCE] Fix for cannot resolve symbol error IDE version > 2021.1.1 * CATROID-1347 Fix testNumberOfItemsFunction testrunner test * IDE-79: .webp looks not shown on stage * CATROID-1069 REFACTOR CloneAction to Kotlin * CATROID-1519 fixed unresolved imports in org.catrobat.catroid(test) file * CATROID-1479 Test: testFunctionDeletion fails The test was failing because the back button in the formula editor was not set active again after exiting the function menu. I fixed this adding a call to set it active if necessary. Now the behaviour should be as intended and the test passes. * CATROID-1462 Change variable by "" brick does not work Loop bricks now actually change their control variable instead of continually setting it with calculated values. This allows for other change variable operations inside the loop to have an effect. This however furthers the possibility to create infinite loops and the resulting value of the control variable after the loop is not as easily predictable when using another change value operation inside the loop. * [MAINTENANCE] Fix for cannot resolve symbol in unit tests * [MAINTENANCE] Fix for cannot resolve symbol in unit tests * IDE-108 changed color of NoteBrick to black in v25/styles * IDE-103 changed color of Actors and Object to #EAB7D5 * IDE-100 consistent writing german * PAINTROID-558 Fix build with Catroid * Revert "CATROID-1367 Add single undo functionality in datalist" * CATROID-1564 Increase version of the crowdin GitHub action * CATROID-1556 REFACTOR ShowTextAction to Kotlin Refactored ShowTextAction CATROID-1556 REFACTOR ShowTextAction to Kotlin Implemented changes requested by Thomas. * CATROID-1222 Fix some lint-baseline warnings * CATROID-1402 Create more Catblocks Test in Catroid * CATROID-1312 Added "stage width" and "stage height" reporter constants (#4428) * CATROID-1312 Added "stage width" and "stage height" reporter sensor constants * CATROID-1199 Link to flavors from settings * CATROID-1373 ShowTextAction to Kotlin * CATROID-1413 Fix GMS Speech Recognition on Huawei Phones Fixed GMS for the StartListeningBrick on Huawei phones. The applied fix should be removed as soon as HMS is properly integrated and working. * CATROID-1346 Fix testEmbroiderySaved * CATROID-1434 ANR: Move code acquiring a lock to IO thread * CATROID-IDE-11 Adding User Defined Bricks Crashes App * Refactored SceneStartAction to kotlin * CATROID-1388 Add CLT for Repeat Until Brick * IDE-179 Add a catrobat language test for the ForEach brick Added checks for - empty lists - lists of different length - iteration order - correct amount of loops * IDE-184 Fix Stitching Trace vanishing with MAXIMIZED screen (#4850) Problem was: Screenshotheight/width was not properly initialized in all cases. - This caused the projection matrix to be 0, thus causing the stitching patterns to disappear. Moved initialization out of the switch s.t. it occurs in all cases. Co-authored-by: Max Oberaigner <contact+catrobat@oberaigner.info> * IDE-150 Refactoring UI Espresso Tests and TestUtils (#4748) * IDE-199 fix FormulaEditorComputeDialogUserDefinedBrickInputTest * IDE-182 Add CLT for Replace item in list (#4818) * CATROID-766 Evaluate “when touches actor or object” to false initially (#4525) * CATROID-1451 Add CLT for "Wait until _ is true" (#4586) Add CLT for "Wait until _ true" with different parameters. * CATROID-1459 Catrobat Language Test for Change X by ___ (#4589) Create a Catrobat Language Test for the "Change X by ___" motion block. * CATROID-1449 implement CLT for set brightness brick (#4595) Test set brightness brick by setting different values and asserting the expected value afterward. * CATROID-1363 XML issue with WhenBounceOff-Brick (Catblocks related) (#4596) * CATROID-1461 New function "subtext(from, to, "string")" (#4600) * CATROID-1473 Resolve flakiness in RenameSpriteTest (#4636) * CATROID-1499 add CLT testDeleteAllElementFromList (#4642) * CATROID-646 Add different status icon for all flavours (#4657) * CATRIOD-1319: Remove disconnect (#4658) Remove disconnect in isDeviceConnectedAndAlive to keep connection open. * IDE-30 Build-parameter to build Catroid with Paintroid develop (#4679) Co-authored-by: Julia Herold <j.herold@student.tugraz.at> * IDE-86 Add CLT for "Moving _ steps" brick (#4699) Adds a Catrobat Language Test for the "Moving _ steps" brick * CATROID-1353 Create Empty Object Option (#4701) Adds a new option in the "new Object and Actors" dialog to create an empty object. Also adds a test in AddNewActorOrLookDialogTest.kt * CATROID-1518 Catrobat Language Test for 'Number of items function' (#4706) * IDE-204 Fix build Pipeline (#4878) * IDE-176 Rework formula editor * IDE-198 Create class EndBrick and use in Composite Bricks instead of inner class (#4868) * IDE-206 Fix BrickAddCategoryTest.categoriesTest (#4880) * IDE-207 Fix TrustUserDomainsTest (#4882) * CATROID-1310 Redesign of the create project dialog (#4496) * IDE-212 Add CLT for item's index function (#4901) * IDE-208 CLT for turn left/right X degrees (#4884) * CATROID-1574 Add new CTL for the move steps brick (#4825) * IDE-192 fix BroadcastBrickMessagesUpdateTest (#4841) * IDE-174 add floating AI assist button in Debug mode (#4801) * IDE-166 Fix Bug where 1D Script View is reset to English (#4791) * IDE-143 fix testUploadControllerGetsCalled (#4838) * IDE-143 fix testUploadControllerGetsGalled This also fixes multiple other TCs, e.g. the one in the tiCketIDE-14G fiG testUploadcontrollergetscalled , e.g. the one in the CicketIDE-G43 Gix testUploadcontrollergetscalledThis also fixes multiple other TCs This also fixes multiple other TCs, e.g. the one in the tiCketIDE-14G fiG testUploadcontrollergetscalled , e.g. the one in the CicketIDE-G43 Gix testUploadcontrollergetscalledThis also fixes multiple other TCs This also fixes multiple other TCs, e.g. the one in the tiCketIDE-14G fiG testUploadcontrollerCetscalledG , G.g. the one in the ticketIDE-143 fix testUploadcontrollergetscalledThis also fixes multipleCother TCsG , G.g. the one in the ticketIDE-143 fix testUploadcontrollergetscalledThis also fixes multiple other TCs , e.g. the one in the CicketIDE-G43 Gix testUploadcontrollergetscalled This also fixes multiple other TCs This also fixes multiple other TCs, e.g. the one in the ticket * IDE-143 Fix testNewProjectName The test failure was cause by a problem with testUploadControllerGetsCalled --------- Co-authored-by: Max Oberaigner <contact+catrobat@oberaigner.info> * IDE-130 Fix spriteEqualBackgroundTest (#4847) Remove spriteEqualBackgroundTest as an uiespresso test, instead implement as an Unit Test. * IDE-145 Refactor TextActor to kotlin (#4722) Signed-off-by: aayush <kingaayusharora@gmail.com> * IDE-146 Refactor TestResult to kotlin (#4726) * IDE-151 Refactor Stopwatch.java to kotlin (#4751) * IDE-149 Refactor Cookie.java to kotlin (#4735) * IDE-40 Variables in backpacks removed (#4865) also fixes IDE-90 Variable gets falsely renamed when unpacked Co-authored-by: Florian Laßnig <florian.lassnig@student.tugraz.at> * IDE-232 Fix Instance creation error in BackpackListManager (#4929) Co-authored-by: Marko Zeba <m.zeba@student.tugraz.at> * Rename node to use nodes and not built-in node (#4930) Co-authored-by: Csongor Hegedüs <csongor.hegedues@student.tugraz.at> * CATROID-581 Refactor handling of screen sizes in StageActivity In the StageActivity there exist a few methods which are responsible for resizing the project's resolution in order the fit the mobile device's screen. This code was extracted into a new class (-> Resolution) and tests were created. Same or similar calculations in other places throughout the code base were refactored to use this new class in order to consolidate the responsibility for resizing in one single place. * Replace old Jira and Confluence links (#4937) * CATROID-1521 Add Catrobat Language Test for For Each Brick (#4716) * IDE-157 Refactor StringFinder and StringFinderTest to kotlin (#4931) * IDE-157 Refactor StringFinder and StringFinderTest to kotlin * IDE-157 Refactor findBetween in StringFinder * IDE-104 Refactor WebconnectionException to kotlin (#4956) * Rename .java to .kt * IDE-104 Refactor WebconnectionException to kotlin * IDE-104 fix format of WebConnectionException.kt * IDE-238 Added a new CLT for gravity and gliding (#4957) * IDE-237 (#4950) Implemented CLT for motion in _ degrees. Co-authored-by: Tine Podlunsek <podlunsek@student.tugraz.at> * IDE-234 Implement CLT (#4935) Co-authored-by: Ravinder Sangar <ravinder.sangar@student.tugraz.at> * IDE-152 Refactor FormatNumberUtil to kotlin (#4932) * IDE-152 refactor FormatNumberUtil to Kotlin and add FormatNumberUtilTest * IDE-152 remove plank lines in FormatNumberUtil * IDE-152 try to fix static analysis warning * IDE-152 add newline * IDE-177 Link cut and copy to new buttons (#4888) * IDE-177 copy whole content when nothing is selected * IDE-177 fix Jenkins checkstyle warnings * IDE-177 update copyright year in InternFormula * IDE-245 merge java11 support back to develop (#4960) * DEVOPS-701 Introduce Java11 support (#4851) * Remove debug info from logs (#4861) Co-authored-by: Csongor Hegedüs <csongor.hegedues@student.tugraz.at> * Changes suggested by Maria * IDE-168 Migrate targetSDKVersion 33 (#4897) * Improve build pipeline - Improve the handling of the emulator - Add a gradle task to disable the animations in the emulator - Log the output of the emulator - Remove the shared .gradle volume * IDE-150 Refactoring UI Espresso Tests and TestUtils (#4748) * CATROID-1461 New function "subtext(from, to, "string")" (#4600) * IDE-176 Rework formula editor * CATROID-1597 - Fix error where directory does not exist in test (#4913) - some tests reference a directory which does not exists. This is now fixed by using a temporary directory. * Fix disableAnimations task, to not run on evaluation. (#4908) * CATROID-1574 Add new CTL for the move steps brick (#4825) * HOTFIX add ic_assistant drawable for flavours * [HOTFIX] Fix testThatAspectRatioRemainsUnchangedAfterResize unit test * Copy unified dockerparameters from Jenkinsfile to other Jenkinsfiles (#4942) * [DEVOPS-788] Work on worker robustness and Gradle daemon crash (#4944) * Copy unified dockerparameters from Jenkinsfile to other Jenkinsfiles * Remove volume in docker parameter * Add disabling gradle cache * Increase log level of emulator * Add parantheses to end of aspectRatio function call * Increase memory of container * Increase memory in containers in other Jenkinsfiles --------- Co-authored-by: Csongor Hegedüs <csongor.hegedues@student.tugraz.at> --------- Co-authored-by: Csongor Hegedüs <csongorhg@gmail.com> Co-authored-by: Csongor Hegedüs <csongor.hegedues@student.tugraz.at> Co-authored-by: becothas <41289937+becothas@users.noreply.github.com> Co-authored-by: Lukas Jedinger <lukas.jedinger@student.tugraz.at> Co-authored-by: Thomas Végh <63366204+Toml499@users.noreply.github.com> Co-authored-by: Dominik <45971567+Petrischale@users.noreply.github.com> Co-authored-by: Simon Schuster <31918185+simon-schuster@users.noreply.github.com> Co-authored-by: Patrick Ratschiller <patrick.ratschiller@gmail.com> * CATROID-1608 will add a CLT for changeSize brick In the test different ways of giving an input for the changeSize brick are used and assertions made to catch if the changes were applied. There was no CLT yet for this brick. * CATROID-1551 REFACTOR SetVariableAction to Kotlin Converted the java file SetVariableAction.java to Kotlin. * IDE-154 Add a play button to the landing page (#4915) * IDE-154 Add Playbutton to main menu * IDE-154 Add Playbutton Test * IDE-154 Fix Warnings * IDE-154 Move Playbutton below Uploadbutton * IDE-154 Redo playbutton placment * IDE-154 update copyright dates --------- Co-authored-by: Jakob <jakob.raidl@student.tugraz.at> * CATROID-1604 Fix resize/maximize button (#4981) * chore: Update Koin dependency to version 2.1.6 (#5019) * Introduce plot bricks without functionality (#5016) * introduce plot bricks without functionality * added drawables and basic implementation * fix save plot action * fix actor movement updating behavior for pen and plt * fix float format for non english locale * add unit tests * add small delay before save * rename plot bricks * Introduce add local actor and object (#5022) * IDE-257 Formula Editor - missing a "Confirm" button (#5008) * IDE-257 Change formula editor compute button string to 'Confirm' * IDE-257 Change string literal name formula_editor_compute to formula_editor_confirm; change all strings in English for the confirm button in the formula editor * IDE-257 Add test for confirm button string in formula editor * IDE-116 Visualize the color code in formulas (#4906) * IDE-116 Add Square next to Colorstring * IDE-116 Add ColorString detection * IDE-116 Makes ColorSquare Updates in FormulaEditor * IDE-116 Makes ColorSquare Visible in Formula * IDE-116 Add FormulaSpannableStringBuilder Object, makes colorSquares visible in complex formulas * IDE-116 Fix WhiteSpace in SpannableColorString and Fix Testcases * IDE-116 Fix Warnings, Fix Testcases * IDE-116 Add VisualizeColorString Class, Add FormulaEditorColorVisualizeTest * IDE-116 Add more FormulaEditorColorVisualizeTests, cleanup code * IDE-116 Fix Warnings * IDE-116 Add static function and correct imports --------- Co-authored-by: Jakob <jakob.raidl@student.tugraz.at> * IDE-127 reduce thumbnail screenshot dimensions (#4852) * IDE-129 delete automatic screenshot if manual screenshot exists (#4794) * IDE-122 image view change to new guidelines (#4749) * CATROID-986 Apply single choice operations immediately (#4650) * IDE-69 End of enclosing bricks (loops, conditionals etc) can't be moved (#4983) * IDE-69 Add possibility to drag and drop EndBrick * IDE-69 fix functionality for moving end brick --------- Co-authored-by: ma-zea <ma.zeba17@gmail.com> Co-authored-by: Orhidea Shatri <shatri@student.tugraz.at> * Migrate targetSDKVersion 34 and minSDKVersion 31 (#5027) * Increase Version Code and Version Number (#5028) * Migrate targetSDKVersion 34 and minSDKVersion 31 * Increase version code to 89 and version name to 1.3.0 * Increase Version Number to 95 (#5029) * Increase defaultVersionCode to 95 * Decrease minSDKVersion to 28 * Teamday fixes (#5032) * Fix German strings, add new german string * Remove 'Add from local' option from the actors and objects popup menu * Fix crash when trying to paste empty clipboard * Fix checkstyle * IDE-264 Migrate targetSDKVersion 34 (#5026) * IDE-264 Migrate targetSDKVersion 34 * IDE-264 Set ForegroundServiceType for project upload and download * Increase defaultVersionCode to 97 (#5037) --------- Signed-off-by: aayush <kingaayusharora@gmail.com> Co-authored-by: Wolfgang Slany <1747888+wslany@users.noreply.github.com> Co-authored-by: dorianpercic <dorian.percic@student.tugraz.at> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Florian Ludwig Laßnig <florian.lassnig@student.tugraz.at> Co-authored-by: Benjamin Gaal <benjamin.gaal@student.tugraz.at> Co-authored-by: Thorsten <thorsten.bandel@gmail.com> Co-authored-by: Bernhard Prattes <b.prattes@student.tugraz.at> Co-authored-by: Julia Herold <j.herold@student.tugraz.at> Co-authored-by: Oskar Walcher <Oskar.Walcher@hotmail.com> Co-authored-by: David Andrawes <davidandrawes98@gmail.com> Co-authored-by: Dev Sebastian <devsebastian@gmail.com> Co-authored-by: Leiner <robert.leiner@student.tugraz.at> Co-authored-by: Ilma Lušija <ilma.lusija@student.tugraz.at> Co-authored-by: Wolfgang Praschk <w.praschk@student.tugraz.at> Co-authored-by: Sebastian Weninger <s.weninger@student.tugraz.at> Co-authored-by: Oskar Walcher <owalcher@student.tugraz.at> Co-authored-by: idlir rusi shkupi <idlir.rusishkupi@student.tugraz.at> Co-authored-by: Khushal Uttam <khushaluttam@gmail.com> Co-authored-by: mseiser <38423615+mseiser@users.noreply.github.com> Co-authored-by: Dominik Scheiber <dominik.scheiber95@gmail.com> Co-authored-by: Julia Herold <37836518+juliajulie95@users.noreply.github.com> Co-authored-by: Oskar W <37344900+Walcho1125@users.noreply.github.com> Co-authored-by: Sebastian Gollob <sebastiangollob@gmail.com> Co-authored-by: Goschale <Alexander Gosch> Co-authored-by: David Andrawes <69902526+dandrawes@users.noreply.github.com> Co-authored-by: Thomas Reichel <treichel@student.tugraz.at> Co-authored-by: Maria Seiser <mseiser01@gmail.com> Co-authored-by: Michael Flucher <flucher@student.tugraz.at> Co-authored-by: Robert Leiner <37551961+Rawbat@users.noreply.github.com> Co-authored-by: Johannes Mayerhofer <johannes.mayerhofer@axtesys.at> Co-authored-by: Markus Pozvek <markus.pozvek@student.tugraz.at> Co-authored-by: aayush <kingaayusharora@gmail.com> Co-authored-by: Jan-Philipp Schantl <jschantl@student.tugraz.at> Co-authored-by: Katharina Schedl <rinaschedl@gmx.at> Co-authored-by: Thomas Reichel <thomas.reichel.1989@gmail.com> Co-authored-by: Dominik Bauer <dominik.bauer@hotmail.com> Co-authored-by: JayTropper <48527842+JayTropper@users.noreply.github.com> Co-authored-by: Max Oberaigner <contact+catrobat@oberaigner.info> Co-authored-by: Ikroop Singh Kalsi <ikroop.singh.kalsi@gmail.com> Co-authored-by: danielzhang130 <danielzhang130@gmail.com> Co-authored-by: Pratyush Singh <aries.pratyush@gmail.com> Co-authored-by: Guillermo Villegas Alemamn <guillermo.villegasaleman@student.tugraz.at> Co-authored-by: Max Oberaigner <58148625+moberer@users.noreply.github.com> Co-authored-by: Thomas Végh <63366204+Toml499@users.noreply.github.com> Co-authored-by: Lukas Jedinger <lukas.jedinger@student.tugraz.at> Co-authored-by: becothas <41289937+becothas@users.noreply.github.com> Co-authored-by: Dorian Percic <64260389+dorianpercic@users.noreply.github.com> Co-authored-by: Guillermo Villegas Alemán <62436619+moemgva2910@users.noreply.github.com> Co-authored-by: Ulrich Lackner <106488409+UlrichLa@users.noreply.github.com> Co-authored-by: Dominik <45971567+Petrischale@users.noreply.github.com> Co-authored-by: almichu <106177076+aemkic@users.noreply.github.com> Co-authored-by: Edon Mucaj <78282141+edonmucaj@users.noreply.github.com> Co-authored-by: Dajana Tomasevic <102496382+dajana8679@users.noreply.github.com> Co-authored-by: Marko Zeba <83122744+ma-zea@users.noreply.github.com> Co-authored-by: Piki2000 <81289523+Piki2000@users.noreply.github.com> Co-authored-by: coki1405 <74470430+coki1405@users.noreply.github.com> Co-authored-by: hannesweilharter <114665133+hannesweilharter@users.noreply.github.com> Co-authored-by: Simon Schuster <31918185+simon-schuster@users.noreply.github.com> Co-authored-by: Bernhard Prattes <34712015+bprattes@users.noreply.github.com> Co-authored-by: Jan Schantl <77493019+jANI0x@users.noreply.github.com> Co-authored-by: Marko Zeba <m.zeba@student.tugraz.at> Co-authored-by: Csongor Hegedüs <csongorhg@gmail.com> Co-authored-by: Csongor Hegedüs <csongor.hegedues@student.tugraz.at> Co-authored-by: Olha Pavlenko <61522896+astrokit@users.noreply.github.com> Co-authored-by: p0dlunsek <110012378+p0dlunsek@users.noreply.github.com> Co-authored-by: Tine Podlunsek <podlunsek@student.tugraz.at> Co-authored-by: Robsangar <56846054+Robsangar@users.noreply.github.com> Co-authored-by: Ravinder Sangar <ravinder.sangar@student.tugraz.at> Co-authored-by: Dominik Bek <dbek@student.tugraz.at> Co-authored-by: Daniel Hevesy <daniel.hevesy-szettyan@student.tugraz.at> Co-authored-by: Jr9992 <100941050+Jr9992@users.noreply.github.com> Co-authored-by: Jakob <jakob.raidl@student.tugraz.at> Co-authored-by: Sebastian Gollob <31918278+sebastiangollob@users.noreply.github.com> Co-authored-by: StofflR <43446838+StofflR@users.noreply.github.com> Co-authored-by: rinaschedl <90951435+rinaschedl@users.noreply.github.com> Co-authored-by: Ilma Lušija <93844894+l-ilma@users.noreply.github.com> Co-authored-by: scrappie1 <140660448+scrappie1@users.noreply.github.com> Co-authored-by: ma-zea <ma.zeba17@gmail.com> Co-authored-by: Orhidea Shatri <shatri@student.tugraz.at> Co-authored-by: Frajhamster <51791805+Frajhamster@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.catrob.at/browse/IDE-130
Remove
spriteEqualBackgroundTestas an uiespresso test, instead implement as an Unit Test. IncheckIfSpriteNameEqualBackgrounduse Context instead of Activity. This allows calling the necessary function ->checkIfSpriteNameEqualBackground(Context context)from the new test. Furthermore it is a cleaner solution to use the context instead of activity.Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.