-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IDE-210 Improve workflow when packing scripts #4988
base: develop
Are you sure you want to change the base?
Conversation
The test is not terminating because of the last line of the test code (toast message is displayed). Unfortunatey, I couldn't find the reason. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, please fix issue highlighted in the comment.
Also please fix Detekt warning in ScriptFragment.java.
@Test | ||
public void testAddToBackpackWithEmptyBrickSelection() { | ||
openActionBarMenu(); | ||
onView(withText("Backpack")).perform(click()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exchange withText("Backpack") with withText(R.string.backpack), so the test can work with different languages
When the script packing selection for a backpack is empty and the checkmark is pressed, a toast message with following text is displayed: "Selection for packing is empty".
https://catrobat.atlassian.net/browse/IDE-210
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.