Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAINTROID-271: changed color previews under MIUI 12 Darkmode #1065

Merged
merged 2 commits into from
Jul 18, 2022
Merged

PAINTROID-271: changed color previews under MIUI 12 Darkmode #1065

merged 2 commits into from
Jul 18, 2022

Conversation

JulianJautz
Copy link
Contributor

@JulianJautz JulianJautz commented Apr 4, 2022 •
edited
Loading

MIUI 12 darkmode inverts colors on screen, which leads to wrong colors (primarily in color picker)
disabling the dark mode in the app prevents this inversion

For QA reviewer: please test the changes on non Google devices to ensure that disabling the dark mode in the app doesn't interfere with dark mode on device.

https://jira.catrob.at/browse/PAINTROID-271

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

JulianJautz and others added 2 commits April 2, 2022 10:28
@JulianJautz
PAINTROID-271: MIUI 12 darkmode inverts colors
119101b 
prohibit use of dark mode in paintroid

* MIUI 12 darkmode inverts colors on screen, which leads to wrong colors (primarily in color picker)

* disabling the dark mode in the app prevents this inversion
Merge branch 'develop' of https://github.com/Catrobat/Paintroid into …
4491abe 
…PAINTROID-271_prevent_color_inversion_MIUI_12_dark
ThorstenBandel
ThorstenBandel approved these changes Jul 16, 2022
View reviewed changes
Copy link
Contributor

@ThorstenBandel ThorstenBandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FromG
FromG approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@FromG FromG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@FromG FromG merged commit cfa17e6 into Catrobat:develop Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FromG FromG FromG approved these changes

@ThorstenBandel ThorstenBandel ThorstenBandel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JulianJautz @ThorstenBandel @FromG