Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paintroid 356: Changing orientation resets image when image shared to app #1095

Merged
merged 9 commits into from
Jul 14, 2022
Merged

Paintroid 356: Changing orientation resets image when image shared to app #1095

merged 9 commits into from
Jul 14, 2022

Conversation

SebastianGrief
Copy link
Contributor

@SebastianGrief SebastianGrief commented May 16, 2022 •
edited
Loading

Now checking if there was a state saved before to not reset on every onCreate.

https://jira.catrob.at/browse/PAINTROID-356

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

@SebastianGrief
PAINTROID-356 Switching orientation resets everything after image fro…
e32bf1e 
…m intent

SavedInstanceState wasn't considered in onCreate which leads to a fresh init every time onCreate is called with an intent.
@SebastianGrief
Merge branch 'develop' of https://github.com/Catrobat/Paintroid into …
c19eca5 
…PAINTROID-356
@SebastianGrief
Merge branch 'develop' of https://github.com/Catrobat/Paintroid into …
07e2bd5 
…PAINTROID-356
@SebastianGrief
PAINTROID-356 Switching orientation resets everything after image fro…
34c88f8 
…m intent

SavedInstanceState wasn't considered in onCreate which leads to a fresh init every time onCreate is called with an intent.
Added a test
Changed a Testcase to use
@SebastianGrief
Merge branch 'develop' of https://github.com/Catrobat/Paintroid into …
37b6a18 
…PAINTROID-356
Electronix1337
Electronix1337 approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@Electronix1337 Electronix1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThorstenBandel ThorstenBandel merged commit 162bbe3 into Catrobat:develop Jul 14, 2022
SebastianGrief added a commit to SebastianGrief/Paintroid that referenced this pull request Sep 12, 2022
@SebastianGrief
Paintroid 356: Changing orientation resets image when image shared to…
2aa435f 
… app (Catrobat#1095)

PAINTROID-356 Switching orientation resets everything after image from intent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Electronix1337 Electronix1337 Electronix1337 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SebastianGrief @Electronix1337 @ThorstenBandel