Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAINTROID-410 Update Paintroid to use Window Metrics instead of Display #1108

Conversation

Electronix1337
Copy link
Contributor

@Electronix1337 Electronix1337 commented May 30, 2022

Made a distinction between API >= 30 (R) and API < 30 (R) to get the display size. For API < 30 the code to get the display size is unchanged and for API >= 30, we are now using the WindowMetrics API to retrieve display size. Also updated every Copyright statement to current year, 2022.

https://jira.catrob.at/browse/PAINTROID-410

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

Copy link
Contributor

@FromG FromG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
relevant changes happen in bitmapintegrationtest and mainactivityhelper. Rest are file header changes.

Made a distinction between API >= 30 (R) and API < 30 (R) to get the display size. Also updated every Copyright statement to current year, 2022.
@Electronix1337 Electronix1337 force-pushed the PAINTROID-410_Update_Paintroid_to_use_Window_Metrics_instead_of_Display branch from fdc010f to 7506462 Compare June 20, 2022 08:28
@ThorstenBandel ThorstenBandel merged commit eb0e5a7 into Catrobat:develop Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants