Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAINTROID-431 deleting unused file log.java #1117

Conversation

akebu6
Copy link
Contributor

@akebu6 akebu6 commented Jun 13, 2022

Refactored the log test in test/java/android/util from Java to Kotlin. Then, later realised file was never in use from the original nor the new branch and hence deleted the file

Ticket: https://jira.catrob.at/browse/PAINTROID-431

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

@akebu6 akebu6 changed the title [task]: refactored log.java test to kotlin PAINTROID-431 refactoring log test from Java to Kotlin Jun 13, 2022
FromG
FromG previously requested changes Jul 13, 2022
Copy link
Contributor

@FromG FromG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix static warnings on jenkins please.

@akebu6
Copy link
Contributor Author

akebu6 commented Jul 13, 2022

Got it, will do

@akebu6
Copy link
Contributor Author

akebu6 commented Jul 13, 2022

Any idea how I can fix the static warnings? I noticed them but wasn't sure how to go about fixing them

@FromG
Copy link
Contributor

FromG commented Jul 13, 2022

start
first you click on the details

2
then you have this option where it shows how many static warnings you have

3
when you click on the static warnings you will get to the different errors which occured.
by clicking on the errors you can then see which files are affected.

4
if you further click on the file. you can then go to the exact line in the code.

5
here you can exactly see the warning in the code.

in this example ExpressionBodySyntax you should write it like this:
fun d(tag: String, msg: String): Int = 0
i think there is also a option for converting to expressionbodysyntax in android studio.

Furthermore you will also be able to see the tests which failed on jenkins.
example from a different pr:
testcases

these will only appear after your static warnings are resolved.

@akebu6
Copy link
Contributor Author

akebu6 commented Jul 13, 2022

all right, let me work on them

[chore]: added expressionBodySyntax

made syntax changes to the log test file

[chore]: modified file

[chore]: deleted file
@akebu6 akebu6 force-pushed the PAINTROID-431_refactoring-log-test-from-java-to-kotlin branch from 48dada6 to 7824d89 Compare August 29, 2022 13:45
@akebu6
Copy link
Contributor Author

akebu6 commented Sep 10, 2022

@FromG the changes requested have been worked on, tests pass locally and on Jerkins. The file was deleted as it had no usages in both the develop branch and the new branch

@ThorstenBandel ThorstenBandel changed the title PAINTROID-431 refactoring log test from Java to Kotlin PAINTROID-431 deleting unsed file log test Nov 17, 2022
@ThorstenBandel ThorstenBandel changed the title PAINTROID-431 deleting unsed file log test PAINTROID-431 deleting unused file log.java Nov 17, 2022
Copy link
Contributor

@ThorstenBandel ThorstenBandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ThorstenBandel ThorstenBandel merged commit f61f587 into Catrobat:develop Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants