-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAINTROID-431 deleting unused file log.java #1117
PAINTROID-431 deleting unused file log.java #1117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix static warnings on jenkins please.
Got it, will do |
Any idea how I can fix the static warnings? I noticed them but wasn't sure how to go about fixing them |
all right, let me work on them |
[chore]: added expressionBodySyntax made syntax changes to the log test file [chore]: modified file [chore]: deleted file
48dada6
to
7824d89
Compare
@FromG the changes requested have been worked on, tests pass locally and on Jerkins. The file was deleted as it had no usages in both the develop branch and the new branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Refactored the log test in test/java/android/util from Java to Kotlin. Then, later realised file was never in use from the original nor the new branch and hence deleted the file
Ticket: https://jira.catrob.at/browse/PAINTROID-431
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.