Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAINTROID-486 Keyboad does not hide after leaving RGB-View #1169

Merged
merged 1 commit into from
Feb 5, 2023

Conversation

Smarshal21
Copy link
Contributor

Please enter a short description of your pull request and add a reference to the Jira ticket.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

untitled

Fixed Keyboad does not hide after leaving RGB-View

@Smarshal21
Copy link
Contributor Author

@mfuchs @dldnhf @meisterluk @clempe can you please review this PR and let me know the changes

@meisterluk
Copy link
Contributor

I still don't know why you always tag me. I am not involved in Catrobat projects anymore since 2015. So please proceed without me. I will ignore any future requests by Catrobat.

@Smarshal21
Copy link
Contributor Author

@exland can you please review this PR

@Lenkomotive
Copy link
Contributor

Hey @Smarshal21!
The fix itself looks good.
Have you ran the tests, especially espresso, locally? In Jenkins 69 of them failed (Usually ~15 fail). Please verify whether your fix had an influence on this. And please write a test in ColorDialogIntegrationTest.java to verify your solution.

Cheers

Copy link
Contributor

@Lenkomotive Lenkomotive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@exland exland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix

@Smarshal21
Copy link
Contributor Author

@exland can i get this pr merged ?

Copy link
Contributor

@juliajulie95 juliajulie95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@juliajulie95 juliajulie95 merged commit a7b0185 into Catrobat:develop Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants