Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAINTROID-519 Changing stroke-tip type triggers undo action #1174

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

Lenkomotive
Copy link
Contributor

@Lenkomotive Lenkomotive commented Dec 21, 2022

PAINTROID-519 Changing stroke-tip type triggers undo action

PAINTROID-519

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

@tanmaySinha16
Copy link

@Lenkomotive hello ,I am Tanmay information science undergrad. I am new to open source and I have some knowledge in kotlin and android development . I am interested in this organization ,can you pls guide me from where I should start.

@Lenkomotive
Copy link
Contributor Author

Lenkomotive commented Dec 25, 2022

@tanmaySinha16
Hey Tanmay!
If you scroll down the github page (https://github.com/Catrobat/Paintroid) of this project you can find information about how to contribute.
Cheers :)

@Samuel-Aktar-Laskar
Copy link

Hey, I have created a pull request. I am new to open source.
It says it requires 2 reviews. I am not understanding. Is this project active? Are the organizations members active? I also messaged in google groups but no reply came?

Copy link
Contributor

@juliajulie95 juliajulie95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@juliajulie95 juliajulie95 merged commit 42f9a37 into Catrobat:develop Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants