Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAINTROID-525 toolspecific options are hidden after leaving fullscree… #1178

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

Lenkomotive
Copy link
Contributor

@Lenkomotive Lenkomotive commented Jan 1, 2023

showToolOptions is called when exiting fullscreen, if they were shown before entering fullscreen.

PAINTROID-525

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

@Lenkomotive Lenkomotive force-pushed the PAINTROID-525 branch 2 times, most recently from 4b54ca9 to cecf109 Compare January 1, 2023 17:10
@juliajulie95
Copy link
Contributor

@Lenkomotive
I think we should save the state before maximizing.
Now it works if the tool options were not hidden before maximizing, but if they were hidden before they then appear.
My proposoal:
If the tool options were hidden before maximizing, they should be hidden after exiting full screen.
If they were not hidden before maximizing, they should open again after exitting fullscreen (as it currently does)

@Lenkomotive
Copy link
Contributor Author

You are right! I will change it.

@juliajulie95 juliajulie95 merged commit 73096f2 into Catrobat:develop Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants