Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAINTROID-526 Non-drawing tools show old stroke in zoomed in window #1181

Merged
merged 1 commit into from
Mar 7, 2023
Merged

PAINTROID-526 Non-drawing tools show old stroke in zoomed in window #1181

merged 1 commit into from
Mar 7, 2023

Conversation

Lenkomotive
Copy link
Contributor

@Lenkomotive Lenkomotive commented Jan 3, 2023 •
edited
Loading

Non-drawing tools show old stroke in zoomed in window

PAINTROID-526

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

@Lenkomotive Lenkomotive force-pushed the PAINTROID-526 branch 2 times, most recently from 83dc35b to 95b9906 Compare January 3, 2023 12:14
@juliajulie95
Copy link
Contributor

juliajulie95 commented Mar 6, 2023 •
edited
Loading

Fix works, please resolve the conflicts for merging & message me afterwards

juliajulie95
juliajulie95 approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@juliajulie95 juliajulie95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@juliajulie95 juliajulie95 merged commit d328de0 into Catrobat:develop Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exland exland exland approved these changes

@juliajulie95 juliajulie95 juliajulie95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lenkomotive @juliajulie95 @exland