Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAINTROID-399 Fix contrast of text color to background color #1186

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

foenabua
Copy link
Contributor

@foenabua foenabua commented Jan 13, 2023

https://jira.catrob.at/browse/PAINTROID-399

Added new colors according to the ticket. However it was not possible to change the color of the Color Picker Tab Icon with this since the icon is an image must be dealt separately. Furthermore the Color Picker Transparent Color which used a checkered grey-white image, which was also noticed by Google for contrast issues, was not adressed in the mock-ups in the ticket. However it is worth mentioning for future tickets.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

Add new colors for satisfying contrast according to Google Play.
@juliajulie95
Copy link
Contributor

Thank you!

@juliajulie95 juliajulie95 merged commit c3a8f59 into Catrobat:develop Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants