Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAINTROID-475 Refactor test cases from Java to Kotlin #1203

Closed
wants to merge 2 commits into from
Closed

PAINTROID-475 Refactor test cases from Java to Kotlin #1203

wants to merge 2 commits into from

Conversation

Lenkomotive
Copy link
Contributor

@Lenkomotive Lenkomotive commented Feb 3, 2023 •
edited
Loading

PAINTROID-475

fixed failing tests in:

  • ColorDialogIntegrationTest.kt
  • FillToolIntegrationTest.kt
  • FlipToolIntegrationTest.kt
  • ShapeToolEraseIntegrationTest.kt
  • ShapeToolOrientationIntegrationTest.kt

note:
ColorDialogIntegrationTest.testSaveColorHistoryInCatrobatFile worked when tested before rebasing on fresh develop branch. Between Akebus commit and now there must be some issue in the ColorHistory functionallity.

Also checkout:
PAINTROID-508
PAINTROID-518

@foenabua this might be of your interest

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

bakicelebi
bakicelebi approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@bakicelebi bakicelebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Aditya3815
Copy link

hello, everyone I want to contribute to this project. Can you tell some good-first issues?

@Aditya3815
Copy link

I also want to join the Gsoc program for this project.

@ThorstenBandel
Copy link
Contributor

The build on Jenkins doesnt work, there seems to be some problem with the checkout already

@ThorstenBandel
Copy link
Contributor

@Aditya3815 please take a look at our readme in the mainpage of our project, there is everything you need to know, if you found a ticket, comment on it that you want to take it.

@Lenkomotive
Copy link
Contributor Author

@ThorstenBandel The last build worked. There must have been some issue with Jenkins.

SebastianGrief
SebastianGrief requested changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@SebastianGrief SebastianGrief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflicts please.

SebastianGrief
SebastianGrief requested changes Mar 13, 2023
View reviewed changes
...c/androidTest/java/org/catrobat/paintroid/test/espresso/dialog/ColorDialogIntegrationTest.kt Show resolved Hide resolved
...c/androidTest/java/org/catrobat/paintroid/test/espresso/dialog/ColorDialogIntegrationTest.kt
}

@Test
fun testSaveColorHistoryInCatrobatFile() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one doesn't pass at the moment, but should work again once PR-1225 is merged.

@SebastianGrief
Copy link
Contributor

Resolve conflicts please.

SebastianGrief
SebastianGrief requested changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@SebastianGrief SebastianGrief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflicts please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianGrief SebastianGrief SebastianGrief requested changes

@bakicelebi bakicelebi bakicelebi approved these changes

@exland exland exland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Lenkomotive @Aditya3815 @ThorstenBandel @SebastianGrief @exland @bakicelebi @akebu6