Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAINTROID-545 Zooming while cursor tool is down deletes the already drawn line #1206

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

bakicelebi
Copy link
Contributor

@bakicelebi bakicelebi commented Feb 8, 2023

PAINTROID-545

Fixed the bug, zooming while drawing with cursor does not delete the already drawn line anymore

Please enter a short description of your pull request and add a reference to the Jira ticket.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

Lenkomotive
Lenkomotive previously approved these changes Feb 13, 2023
Copy link
Contributor

@Lenkomotive Lenkomotive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same bug exists in the LineTool as well. Please check this out too.

@bakicelebi
Copy link
Contributor Author

@Lenkomotive fixed 👍

Copy link
Contributor

@SebastianGrief SebastianGrief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SebastianGrief SebastianGrief merged commit e667a12 into Catrobat:develop Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants