Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAINTROID-504 Fix CatrobatImageIOIntegrationTests #1226

Merged
merged 1 commit into from
Mar 26, 2023

Conversation

khalid-nasralla
Copy link
Contributor

@khalid-nasralla khalid-nasralla commented Mar 13, 2023

PAINTROID-504

The problem was that the test assumed that the overwrite view will pop up but it won't happen because before the test, there shouldn't be the same file already on jenkins, so there won't be a pop up asking if you want to overwrite. It just saves it and is done.
File also gets cleaned up now after executing the test.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

@khalid-nasralla khalid-nasralla force-pushed the PAINTROID-504 branch 3 times, most recently from a03bc0a to eab530d Compare March 16, 2023 04:40
Copy link
Contributor

@Lenkomotive Lenkomotive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check comment

@ThorstenBandel ThorstenBandel merged commit 7bab334 into Catrobat:develop Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants