Rename astro namespace to celestia::astro #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ajtribick
commented
Oct 18, 2023
ajtribick
commented
- Tidy up includes in astro.h/astro.cpp
- Replace snprintf with fmt in astro.cpp
ajtribick
force-pushed
the
astro
branch
3 times, most recently
from
6756be0 to
1456261
Compare
375gnu
reviewed
Oct 18, 2023
375gnu
reviewed
Oct 18, 2023
ajtribick
force-pushed
the
astro
branch
3 times, most recently
from
c80e248 to
b69d0a0
Compare
375gnu
reviewed
Oct 18, 2023
ajtribick
force-pushed
the
astro
branch
2 times, most recently
from
12703b0 to
62d0828
Compare
|
I'm not prepared to mess with the internals of the JD/calendar conversions right now, hence sprinkling |
375gnu
requested changes
Oct 20, 2023
- Tidy up includes in astro.h/astro.cpp - Replace snprintf with fmt in astro.cpp - Replace Date::toCStr() with Date::toString() returning std::string
|
Kudos, SonarCloud Quality Gate passed! |
375gnu
approved these changes
Oct 20, 2023
levinli303
reviewed
Oct 24, 2023
| snprintf(date, sizeof(date), "%04d-%02d-%02dT%02d:%02d:%08.5fZ", | ||
| year, month, day, hour, minute, seconds); | ||
| return date; | ||
| return fmt::format("{:04}-{:02}-{:02}T{:02}:{:02}:{:02}:{:08.5f}Z"sv, |
There was a problem hiding this comment.
@ajtribick we missed an argument here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.