Test components #42
Merged
Test components #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johncalesp
commented
Feb 17, 2023
johncalesp
commented
- Unit test for main sections of the UI and utils.js
- Made small changed on the styling of local GPU.
…| PerfBarContainer
michaelshin
approved these changes
Feb 17, 2023
| expect(root).toBeTruthy(); | ||
| }); | ||
| }); | ||
| test("Render App correctly, it must show begin analysis button", () => { |
There was a problem hiding this comment.
The comment isn't necessarily true as it will be disconnected.
There was a problem hiding this comment.
Changed the comment and testing title
| render(<App />); | ||
| // For testing there is no default socket connection. It will show the warning screen | ||
|
|
||
| expect(screen.getByText(/connection has been lost to the profiler. please reconnect the profiler and double check your ports then click connect/i)).toBeTruthy(); |
There was a problem hiding this comment.
I would just double check if the App renders something instead of relying on a string. That seems very brittle
There was a problem hiding this comment.
added reconnect button to the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.