Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension size reduction #44

Merged
merged 6 commits into from
Mar 2, 2023
Merged

Extension size reduction #44

merged 6 commits into from
Mar 2, 2023

Conversation

johncalesp
Copy link
Contributor

React App build reduction:

  • Uninstall packages that we are not being used (react-vis, web-vitals)
  • Change explicit imports for Bootstrap

VS Code extension size reduction:

  • Uninstall libraries that are not being used (react, react-dom, bootstrap, etc)
  • Use esbuild for building the extension (recommended by Microsoft)
  • Change .vscodeignore to not include node_modules and react-ui folder
  • Change build_vsix.sh to no longer require to install react and other dependencies

Final size is 471.06 KB (from 209MB)

jimgao1
jimgao1 approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@jimgao1 jimgao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johncalesp johncalesp merged commit 7e28b14 into main Mar 2, 2023
@johncalesp johncalesp deleted the build-size-reduction branch March 2, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimgao1 jimgao1 jimgao1 approved these changes

@michaelshin michaelshin Awaiting requested review from michaelshin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johncalesp @jimgao1