Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Habitat handle no supported gpu #48

Merged
merged 3 commits into from
Mar 23, 2023
Merged

Conversation

johncalesp
Copy link
Contributor

Handle the case when local GPU is not supported by Habitat

@@ -18,6 +18,22 @@ const data = [
["RTX4000", 20.2342],
];

const noHabitatData = [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical blocks of code found in 2 locations. Consider refactoring.

@@ -19,6 +19,22 @@ const data = [
["RTX4000", 20.2342],
];

const noHabitatData = [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical blocks of code found in 2 locations. Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Mar 23, 2023

Code Climate has analyzed commit 3d1786b and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

@michaelshin
Copy link
Contributor

Can you add screenshots of these changes?

@jimgao1 jimgao1 self-requested a review March 23, 2023 16:10
Copy link
Contributor

@jimgao1 jimgao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimgao1 jimgao1 merged commit 5ce711f into main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants