-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Providers schema #53
Merged
Merged
Providers schema #53
Changes from 19 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
53a4eae
read local yaml file
johncalesp 19aecda
completed unit testing
johncalesp 8af84cb
Merge branch 'main' into providers-schema
johncalesp 0e103e4
added general yaml schema for external cloud providers | changes unit…
johncalesp c2a7157
changed URL providers to S3
johncalesp 4d2c3c9
get data from multiple urls
johncalesp e62f776
changed extension setting description
johncalesp e000657
merged with main
johncalesp 37dc1d8
changed to centML S3
johncalesp 5d990c2
local tests
johncalesp d59ab65
local changes to skylinesession
johncalesp 4239bcc
merged changes from main
johncalesp 906de83
installation of json parser
johncalesp 9280ad0
Merge branch 'main' into providers-schema
johncalesp f85468d
changed to json schema
johncalesp 16f7930
Merge branch 'main' into providers-schema
johncalesp 0035587
finished reading json from external urls and show incorrect data
johncalesp 4ba6544
Merge branch 'main' into providers-schema
johncalesp d36ae3b
changed unit testing and tested with build script
johncalesp 5c7d0b3
changed default providers settings to empty string
johncalesp 5697d6e
PR review
johncalesp 2349588
changed utils.js file
johncalesp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,14 +29,44 @@ To install, either: | |
Once you have the vsix file, run `code --install-extension vscode*.vsix` to install the extension. | ||
**Note: the file [build_vsix_dev.sh] is only to be used for development** | ||
|
||
**Adding cloud instances to the Deployment Tab:** You can include information about the instances that you use thrugh the extension settings. There you will find an option named **providers** that accepts a list of urls separated by commas. Each url must be a JSON file that follows the schema speficied here : [schema](skyline-vscode/react-ui/src/schema/CloudProvidersSchema.js).<br/> | ||
Addittionally, you need to add the necessary access so the extension can read the file.<br/> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Typo on Additionally There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed |
||
You can use an AWS S3 bucket to store your files. Change CORS settings in Permissions tab. | ||
|
||
**CORS requirements**: | ||
``` | ||
[ | ||
{ | ||
"AllowedHeaders": [], | ||
"AllowedMethods": [ | ||
"GET" | ||
], | ||
"AllowedOrigins": [ | ||
"http://*", | ||
"https://*", | ||
"vscode-webview://*" | ||
], | ||
"ExposeHeaders": [] | ||
} | ||
] | ||
``` | ||
and allow public access to the file | ||
|
||
This is our [file](https://deepview-explorer-public.s3.amazonaws.com/vscode-cloud-providers/providers.json) that you can use as an example. | ||
|
||
|
||
|
||
|
||
|
||
### Backend Installation | ||
This plugin requires Skyline (the installation instruction for which can be found [here](https://github.com/CentML/skyline)) and (optionally) Habitat (used to extrapolate GPU runtimes, instructions found [here](https://github.com/CentML/habitat)). **Skyline must be launched before running this extension.** | ||
|
||
After installation, please make note of the path to the `skyline` binary. To do so, run `which skyline` after ensuring that the `skyline` binary works. This path is different depending on how the backend was installed. Default installation from PyPI will place the binary to `/usr/bin/skyline`, however if you're running the backend in virtual environment it will be in a different location. **You need to launch `skyline` before running this extension.** | ||
|
||
## Usage example | ||
1. Open one of the examples DNN project examples, i.e. [Resnet](https://github.com/CentML/skyline/tree/main/examples/resnet) from Skyline in VSCode | ||
2. Press `Ctrl+Shift+P`, then select `Skyline` from the dropdown list. | ||
2. (Optional) You can add other external cloud instances. Use the CloudProvidersSchema.yaml file as a reference. This file is located under the schemas folder. Once you have created your own yaml file, you can reference the path to this file in the extension settings in **providers** option. The file will be read when the extension is called. | ||
3. Press `Ctrl+Shift+P`, then select `Skyline` from the dropdown list. | ||
3. Click on `Begin Analysis`. | ||
|
||
## Disabling telemetry | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo on "specified"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed