Rename to deepview #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johncalesp
commented
Apr 6, 2023
johncalesp
commented
- Update package.json and extension.ts to use deepview instead of skyline
- Created deepview-explore folder in centml-releases bucket to host future releases
- Small changes to set carbon emissions to null when the instances doesn't have this information (mostly external urls)
- Added License.txt file
…ged build workflow to use deepview
michaelshin
reviewed
Apr 6, 2023
| @@ -32,7 +32,7 @@ const DeploymentTab = ({ numIterations, habitatData,additionalProviders }) => { | |||
| <ProviderPanel | |||
| numIterations={numIterations} | |||
| habitatData={habitatData} | |||
| additionalProviders={additionalProviders} | |||
| cloudProviderURLs={additionalProviders} | |||
There was a problem hiding this comment.
Can you update additionalProviders to be cloudProviderURLs as well?
|
Code Climate has analyzed commit 04a7fa0 and detected 0 issues on this pull request. View more on Code Climate. |
michaelshin
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.