Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle updated energy request with batch size #61

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Handle updated energy request with batch size #61

merged 2 commits into from
Apr 20, 2023

Conversation

michaelshin
Copy link
Contributor

  • Updated protocol so it sends the batch size in an EnergyResponse
  • Pass over the EnergyResponse to the front end and normalize the total energy consumption. This is done by multiplying the ratio of current batch size to the past batch size. This means all the energy runs will use the same number examples

@codeclimate
Copy link

codeclimate bot commented Apr 20, 2023

Code Climate has analyzed commit ffb71b0 and detected 13 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 13

View more on Code Climate.

@michaelshin michaelshin merged commit 1026046 into main Apr 20, 2023
@michaelshin michaelshin deleted the normalize-for-batch-size-for-energy-consumption branch April 27, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johncalesp johncalesp johncalesp approved these changes

@anurlybayev anurlybayev Awaiting requested review from anurlybayev

@jimgao1 jimgao1 Awaiting requested review from jimgao1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelshin @johncalesp