Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if operation_tree has data before access #70

Merged
merged 1 commit into from
May 8, 2023
Merged

Check if operation_tree has data before access #70

merged 1 commit into from
May 8, 2023

Conversation

michaelshin
Copy link
Contributor

  • Ensure operation_tree is not empty before accessing it.
  • This fixes the error found in the screenshot below
    image
  • This bug was annoying to track down so I will improve the debugging process in a future PR

johncalesp
johncalesp approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@johncalesp johncalesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome !

@johncalesp johncalesp merged commit 520b3a5 into main May 8, 2023
@michaelshin michaelshin deleted the fix-index-error branch June 1, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johncalesp johncalesp johncalesp approved these changes

@anurlybayev anurlybayev Awaiting requested review from anurlybayev

@jimgao1 jimgao1 Awaiting requested review from jimgao1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelshin @johncalesp