Redux store #72
Redux store #72
Conversation
johncalesp
commented
May 11, 2023
johncalesp
commented
- State management is handle by redux-store
- Changed unit testing
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
|
||
| export default function Habitat({ habitatData }) { | ||
| export default function Habitat() { |
There was a problem hiding this comment.
Function Habitat has 66 lines of code (exceeds 25 allowed). Consider refactoring.
| ["RTX4000", 20.2342], | ||
| ]; | ||
|
|
||
| const habitatData = { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
| @@ -32,11 +32,14 @@ import { loadJsonFiles } from "../utils/parsers"; | |||
|
|
|||
| import { useSelector } from "react-redux"; | |||
|
|
|||
| const ProviderPanel = ({ habitatData, cloudProviderURLs }) => { | |||
| const ProviderPanel = () => { | |||
There was a problem hiding this comment.
Function ProviderPanel has 346 lines of code (exceeds 25 allowed). Consider refactoring.
|
|
||
| const { ResizeObserver } = window; | ||
|
|
||
| const data = { | ||
| const habitatData = { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
| ["RTX4000", 20.2342], | ||
| ["demo", 1], | ||
| ]; | ||
| const noHabitatData = { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
|
Can you add more details on what you moved to Redux and what each reducer is responsible for? |
| * @returns The VSCode API handle | ||
| */ | ||
| function acquireApi() { | ||
| // if (typeof this.acquireApi.api == 'undefined') { |
| export default function Habitat({ habitatData }) { | ||
| export default function Habitat() { | ||
| const {analysisState} = useSelector((state) => state.analysisStateSliceReducer); | ||
| const habitatData = analysisState["habitat"]; | ||
| const habitatIsDemo = habitatData.predictions?.find( |
There was a problem hiding this comment.
This can be put in the redux state
There was a problem hiding this comment.
yeah, I refactored that part
|
I think this is a good start for us to use Redux. Did you have a way to separate what states should be in the store vs stored locally? If we can keep that consistent, then it would be better to maintain longterm |
| export default function Habitat({ habitatData }) { | ||
| const habitatIsDemo = habitatData.predictions?.find( | ||
| (item) => item[0] === "demo" && item[1] === 1 | ||
| export default function Habitat() { |
There was a problem hiding this comment.
Function Habitat has 65 lines of code (exceeds 25 allowed). Consider refactoring.
| @@ -21,11 +21,13 @@ import { energy_data, unitScale, numberFormat } from "../utils/utils"; | |||
|
|
|||
| import { useSelector } from "react-redux"; | |||
|
|
|||
| const EnergyConsumption = ({ energyData }) => { | |||
| const EnergyConsumption = () => { | |||
There was a problem hiding this comment.
Function EnergyConsumption has 281 lines of code (exceeds 25 allowed). Consider refactoring.
| @@ -32,12 +32,16 @@ import { loadJsonFiles } from "../utils/parsers"; | |||
|
|
|||
| import { useSelector } from "react-redux"; | |||
|
|
|||
| const ProviderPanel = ({ habitatData, cloudProviderURLs }) => { | |||
| const ProviderPanel = () => { | |||
There was a problem hiding this comment.
Function ProviderPanel has 348 lines of code (exceeds 25 allowed). Consider refactoring.
|
|
||
| const WelcomeScreen = ({ analysisState, vscodeApi }) => { | ||
| const WelcomeScreen = () => { |
There was a problem hiding this comment.
Function WelcomeScreen has 38 lines of code (exceeds 25 allowed). Consider refactoring.
| @@ -9,10 +9,12 @@ import { numberFormat } from "../utils/utils"; | |||
|
|
|||
| import { useSelector } from "react-redux"; | |||
|
|
|||
| const DeploymentTab = ({ habitatData,cloudProviderURLs }) => { | |||
| const DeploymentTab = () => { | |||
There was a problem hiding this comment.
Function DeploymentTab has 31 lines of code (exceeds 25 allowed). Consider refactoring.
|
Code Climate has analyzed commit f8c482b and detected 11 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
I added more comments in redux/store/store.js to indicate the responsibilities of each slice. |
