Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Habitat an optional dependency #18

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Conversation

jimgao1
Copy link
Contributor

@jimgao1 jimgao1 commented Nov 5, 2022

This is in reference to #16 (comment).
The change was made such that Habitat will no longer be invoked if it is not installed, effectively making it an optional dependency.

Copy link
Contributor

@michaelshin michaelshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me in general. I recommend the one change I commented but looks good other than that

skyline/analysis/session.py Outdated Show resolved Hide resolved
@jimgao1 jimgao1 requested a review from michaelshin November 7, 2022 21:25
@jimgao1 jimgao1 merged commit d5f4c5c into main Nov 8, 2022
@jimgao1 jimgao1 deleted the nov04-fix-habitat-dependency branch November 8, 2022 21:33
@michaelshin michaelshin mentioned this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants