-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added energy consumption to Skyline #30
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
import datetime | ||
import sqlite3 | ||
|
||
class DatabaseInterface: | ||
def __init__(self, database_name="skyline.sqlite3") -> None: | ||
self.connection = sqlite3.connect(database_name, detect_types=sqlite3.PARSE_DECLTYPES|sqlite3.PARSE_COLNAMES) | ||
self.create_energy_table() | ||
|
||
def create_energy_table(self) -> None: | ||
self.connection.cursor().execute("CREATE TABLE IF NOT EXISTS ENERGY ( \ | ||
entry_point TEXT, \ | ||
cpu_component REAL, \ | ||
gpu_component REAL, \ | ||
ts TIMESTAMP \ | ||
);") | ||
|
||
|
||
class EnergyTableInterface: | ||
def __init__(self, database_connection: sqlite3.Connection): | ||
self.database_connection: sqlite3.Connection = database_connection | ||
|
||
@staticmethod | ||
def is_valid_entry(entry: list) -> bool: | ||
''' | ||
Validates an entry in the Energy table by testing if the length is 3, | ||
and the types match the columns. Note that timestamp is not part of the entry. | ||
Returns True if it is valid, else False | ||
''' | ||
return len(entry) == 3 and type(entry[0]) == str and type(entry[1]) == float \ | ||
and type(entry[2]) == float | ||
|
||
@staticmethod | ||
def is_valid_entry_with_timestamp(entry: list) -> bool: | ||
''' | ||
Validates an entry in the Energy table by testing if the length is 4, | ||
and the types match the columns. Returns True if it is valid, else False | ||
''' | ||
return len(entry) == 4 and type(entry[0]) == str and type(entry[1]) == float \ | ||
and type(entry[2]) == float and type(entry[3]) == datetime.datetime | ||
|
||
def add_entry(self, entry: list) -> bool: | ||
''' | ||
Validates an entry and then adds that entry into the Energy table. Note that current timestamp is added | ||
by this function. Returns False if the entry is not a valid format, or if the insertion failed. Else | ||
returns True | ||
''' | ||
if self.is_valid_entry(entry): | ||
try: | ||
entry.append(datetime.datetime.now()) | ||
cursor = self.database_connection.cursor() | ||
cursor.execute("INSERT INTO ENERGY VALUES(?, ?, ?, ?)", entry) | ||
self.database_connection.commit() | ||
return True | ||
except sqlite3.IntegrityError as e: | ||
print(e) | ||
return False | ||
else: | ||
return True | ||
|
||
def get_latest_n_entries_of_entry_point(self, n: int, entry_point: str) -> list: | ||
''' | ||
Gets the n latest entries of a given entry point | ||
''' | ||
params = [entry_point, n] | ||
cursor = self.database_connection.cursor() | ||
results = cursor.execute("SELECT * FROM ENERGY WHERE entry_point=? ORDER BY ts DESC LIMIT ?;", params).fetchall() | ||
return results |
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can declare this variable outside the try block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason that it should be outside the try block? I'm not sure I understand why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it will be easier to read if all the variables are declared at the beginning of the function. At least the ones that can be