added error messages and memory reset #53
Conversation
johncalesp
commented
May 8, 2023
johncalesp
commented
- Added external method to clear cache in GPU memory
- Added error codes for habitat and energy in protobuf
- Modified try-except blocks for habitat and energy
There was a problem hiding this comment.
I'd call this file memory_utils or something similar
There was a problem hiding this comment.
renamed to utils.py
| @@ -150,47 +150,56 @@ def energy_compute(self) -> pm.EnergyResponse: | |||
| for _ in range(iterations): | |||
| iteration(*inputs) | |||
| energy_measurer.end_measurement() | |||
| resp.total_consumption = energy_measurer.total_energy()/float(iterations) | |||
There was a problem hiding this comment.
Does this change mean a user has to enable CPU monitoring to get energy measurements? What if a user doesn't have access like in cloud instances?
There was a problem hiding this comment.
Actually no, the code is the same as before. I tried on my PC removing access to pyRAPL and the profile will only measure GPU power consumption.
There was a problem hiding this comment.
After looking over the code with John, we determined that the exception is already handled in the measurement
deepview_profile/analysis/session.py
Outdated
| logger.error(message) | ||
| resp.analysis_error.error_message = message | ||
| except: | ||
| logger.error("There was an error running deepview predict") |
There was a problem hiding this comment.
Change "deepview predict" to "DeepView Predict"
|
Code Climate has analyzed commit dd97ec6 and detected 0 issues on this pull request. View more on Code Climate. |
