-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move proxy setup logic from dev machines to proxy VM #1212
Move proxy setup logic from dev machines to proxy VM #1212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good. a few recommendation to keep the proxy server as isolated and simple as possible by removing some unneeded files/configs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm for the first phase for the refactor work
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yb01, zmn223 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* code to use mizar as default cni for arktos * Updated code for deploying arktos with mizar as per CR * Updated code for deploying arktos with mizar * Updated code for mizar cni changes * added code to build arktos-network-controller * Automated mannual steps * updated the guide with appropriate changes * fixed the bootstrap issues * updated the guide and removed the bootstrap script dependency * updated the instance type for on-premise and cloud * Removed the code for checking mizar prerequisites * updated conditions for mizar and changes as per reviewer * Move proxy setup logic from dev machines to proxy VM (#1212) * Move proxy setup to proxy server from dev machine * update proxy setup comments and cleanup unnecessary information * remove proxy log redirect and logrotate service * replace kubernetes.target with multi-user.target * Add a brief introduction to Google Anthos Overall Architecture * Rename tech doc name - CI bot complains (#1218) Co-authored-by: click2cloud-team3 <click2cloud-beta1@click2cloud.net> Co-authored-by: click2cloud-team3 <82659622+click2cloud-team3@users.noreply.github.com> Co-authored-by: Click2cloud-rninja <59909227+Click2Cloud-rninja@users.noreply.github.com> Co-authored-by: click2cloud-team3 <click2cloud-team3@click2cloud.net> Co-authored-by: sonyafenge <45471193+sonyafenge@users.noreply.github.com> Co-authored-by: Ying Huang <sindica2000@yahoo.com>
What type of PR is this?
What this PR does / why we need it:
Current proxy setup logic is on dev machine and using ssh to transfer commands to proxy vm, which is unstable and low efficiency. This PR moved proxy setup process to proxy vm.
Which issue(s) this PR fixes:
Fixes #1036
Special notes for your reviewer:
100 nodes perf test density run finished with result: Success
Does this PR introduce a user-facing change?: