Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move proxy setup logic from dev machines to proxy VM #1212

Merged

Conversation

sonyafenge
Copy link
Collaborator

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
Current proxy setup logic is on dev machine and using ssh to transfer commands to proxy vm, which is unstable and low efficiency. This PR moved proxy setup process to proxy vm.

Which issue(s) this PR fixes:

Fixes #1036

Special notes for your reviewer:
100 nodes perf test density run finished with result: Success

export KUBEMARK_NUM_NODES=100  SCALEOUT_CLUSTER=true NUM_NODES=2 SCALEOUT_TP_COUNT=1 SCALEOUT_RP_COUNT=1 RUN_PREFIX=perf1-101321-1x1x100
export MASTER_DISK_SIZE=500GB MASTER_ROOT_DISK_SIZE=500GB KUBE_GCE_ZONE=us-central1-b MASTER_SIZE=n1-highmem-32 NODE_SIZE=n1-highmem-16 NODE_DISK_SIZE=500GB GOPATH=$HOME/go KUBE_GCE_ENABLE_IP_ALIASES=true KUBE_GCE_PRIVATE_CLUSTER=true CREATE_CUSTOM_NETWORK=true KUBE_GCE_INSTANCE_PREFIX=${RUN_PREFIX} KUBE_GCE_NETWORK=${RUN_PREFIX} ENABLE_KCM_LEADER_ELECT=false ENABLE_SCHEDULER_LEADER_ELECT=false ETCD_QUOTA_BACKEND_BYTES=8589934592 SHARE_PARTITIONSERVER=false LOGROTATE_FILES_MAX_COUNT=200 LOGROTATE_MAX_SIZE=200M KUBE_ENABLE_APISERVER_INSECURE_PORT=true KUBE_ENABLE_PROMETHEUS_DEBUG=true KUBE_ENABLE_PPROF_DEBUG=true TEST_CLUSTER_LOG_LEVEL=--v=2 HOLLOW_KUBELET_TEST_LOG_LEVEL=--v=2 GCE_REGION=us-central1-b
./cluster/kube-up.sh
./test/kubemark/start-kubemark.sh
./_output/dockerized/bin/linux/amd64/kubectl --kubeconfig=./test/kubemark/resources/kubeconfig.kubemark.tp-1 create tenant arktos
SCALEOUT_TEST_TENANT=arktos RUN_PREFIX=perf1-101321-1x1x100 PERF_LOG_DIR=/home/sonyali/logs/perf-test/gce-100/arktos/${RUN_PREFIX}/${SCALEOUT_TEST_TENANT}
mkdir -p $PERF_LOG_DIR
SCALEOUT_TEST_TENANT=arktos RUN_PREFIX=perf1-101321-1x1x100 PERF_LOG_DIR=/home/sonyali/logs/perf-test/gce-100/arktos/${RUN_PREFIX}/${SCALEOUT_TEST_TENANT} nohup perf-tests/clusterloader2/run-e2e.sh --nodes=100 --provider=kubemark --kubeconfig=/home/sonyali/go/src/k8s.io/arktos/test/kubemark/resources/kubeconfig.kubemark-proxy --report-dir=${PERF_LOG_DIR} --testconfig=testing/density/config.yaml > ${PERF_LOG_DIR}/perf-run.log  2>&1  &

Does this PR introduce a user-facing change?:


cluster/gce/gci/configure.sh Outdated Show resolved Hide resolved
cluster/gce/util.sh Outdated Show resolved Hide resolved
cluster/gce/gci/configure.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@yb01 yb01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good. a few recommendation to keep the proxy server as isolated and simple as possible by removing some unneeded files/configs.

Copy link
Collaborator

@yb01 yb01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm for the first phase for the refactor work

@zmn223
Copy link
Collaborator

zmn223 commented Oct 26, 2021

/lgtm

@zmn223
Copy link
Collaborator

zmn223 commented Oct 26, 2021

/approve

@centaurus-cloud-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yb01, zmn223

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@centaurus-cloud-bot centaurus-cloud-bot merged commit 6336ea9 into CentaurusInfra:master Oct 26, 2021
Sindica added a commit that referenced this pull request Nov 3, 2021
* code to use mizar as default cni for arktos

* Updated code for deploying arktos with mizar as per CR

* Updated code for deploying arktos with mizar

* Updated code for mizar cni changes

* added code to build arktos-network-controller

* Automated mannual steps

* updated the guide with appropriate changes

* fixed the bootstrap issues

* updated the guide and removed the bootstrap script dependency

* updated the instance type for on-premise and cloud

* Removed the code for checking mizar prerequisites

* updated conditions for mizar and changes as per reviewer

* Move proxy setup logic from dev machines to proxy VM (#1212)

* Move proxy setup to proxy server from dev machine

* update proxy setup comments and cleanup unnecessary information

* remove proxy log redirect and logrotate service

* replace kubernetes.target with multi-user.target

* Add a brief introduction to Google Anthos Overall Architecture

* Rename tech doc name - CI bot complains (#1218)

Co-authored-by: click2cloud-team3 <click2cloud-beta1@click2cloud.net>
Co-authored-by: click2cloud-team3 <82659622+click2cloud-team3@users.noreply.github.com>
Co-authored-by: Click2cloud-rninja <59909227+Click2Cloud-rninja@users.noreply.github.com>
Co-authored-by: click2cloud-team3 <click2cloud-team3@click2cloud.net>
Co-authored-by: sonyafenge <45471193+sonyafenge@users.noreply.github.com>
Co-authored-by: Ying Huang <sindica2000@yahoo.com>
@sonyafenge sonyafenge deleted the moveproxysetupnew branch February 4, 2022 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

perf test env setup enhancement works
5 participants