Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-4818] Use provider favicon for preprint discover page #2032

Merged

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Oct 17, 2023

Purpose

  • Use provider's favicon when looking at branded preprint discover page

Summary of Changes

  • Add afterModel hook to preprint-discover route to add favicon (same logic as lib/registries/addon/branded/route.ts)
    • Can move this afterModel hook to parent route once preprints landing page rewrite

Screenshot(s)

  • favicon associated with a preprint-provider in admin app and used in the browser tab below
    image

Side Effects

QA Notes

  • Please make sure the preprint provider is using a given favicon in the admin app by going to admin.staging.osf.io/provider_asset_files/<asset_id>/

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6551520933

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 71.167%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/preprints/discover/route.ts 0 3 0.0%
Totals Coverage Status
Change from base Build 6511581413: -0.05%
Covered Lines: 5941
Relevant Lines: 8132

💛 - Coveralls

@futa-ikeda futa-ikeda merged commit a9b403d into CenterForOpenScience:develop Oct 17, 2023
9 checks passed
@futa-ikeda futa-ikeda deleted the preprint-discover-favicon branch October 17, 2023 20:11
@futa-ikeda futa-ikeda added this to the 23.13.0 milestone Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants