-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-4642] Boa Add-on Project PR - Ember Part #2046
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make boa modal findable * save WIP on dataset select * futa wisdom attained/accepted * add action; fetch parents properly * enabled addons enabled * cleanups; fix closemodal
[ENG-4671] Implement submit-to-boa flow for file list and file detail page
Pull Request Test Coverage Report for Build 6827774750
💛 - Coveralls |
* Add file size to boa request * Allow checked out boa file to be submitted * Use sizeInt
adlius
approved these changes
Nov 10, 2023
futa-ikeda
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐍
bp-cos
pushed a commit
to bp-cos/ember-osf-web
that referenced
this pull request
Jan 31, 2024
) * [WIP] first stab at Boa addon ux * make boa modal findable * save WIP on dataset select * futa wisdom attained/accepted * add action; fetch parents properly * enabled addons enabled * cleanups; fix closemodal * Add mirage support for BoA files * Type updates * authenticate addon endpoint request * Add a bit of error handling to mirage * Change logic to populate a node addons * Disable submit to boa if no dataset selected * Add qp to boa upload link * Add placeholder message to dataset select * Update toast messages * CR feedback * Boa bugs (CenterForOpenScience#2047) * Add file size to boa request * Allow checked out boa file to be submitted * Use sizeInt * Circumvent promise-induced bugs (CenterForOpenScience#2049) --------- Co-authored-by: Fitz Elliott <fitz@cos.io> Co-authored-by: Futa Ikeda <futa.ikeda@gmail.com> Co-authored-by: futa-ikeda <51409893+futa-ikeda@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Implement submit-to-boa in file list page and in file details page.
Work done by @felliott and @futa-ikeda 👍 👍 and reviewed by @brianjgeiger 👍
Summary of Changes
Screenshot(s)
N/A
Side Effects
N/A
QA Notes
See QA Test Plan for Boa
Dev/ DevOps Note