Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-4642] Boa Add-on Project PR - Ember Part #2046

Merged
merged 14 commits into from
Nov 10, 2023
Merged

Conversation

cslzchen
Copy link
Collaborator

@cslzchen cslzchen commented Nov 8, 2023

Purpose

Implement submit-to-boa in file list page and in file details page.

Work done by @felliott and @futa-ikeda 👍 👍 and reviewed by @brianjgeiger 👍

Summary of Changes

Screenshot(s)

N/A

Side Effects

N/A

QA Notes

See QA Test Plan for Boa

Dev/ DevOps Note

@coveralls
Copy link

coveralls commented Nov 8, 2023

Pull Request Test Coverage Report for Build 6827774750

  • 15 of 43 (34.88%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 70.49%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/osf-components/addon/components/file-actions-menu/component.ts 3 13 23.08%
lib/osf-components/addon/components/file-actions-menu/submit-to-boa-modal/component.ts 0 18 0.0%
Totals Coverage Status
Change from base Build 6642409593: -0.2%
Covered Lines: 5968
Relevant Lines: 8237

💛 - Coveralls

* Add file size to boa request

* Allow checked out boa file to be submitted

* Use sizeInt
@cslzchen cslzchen marked this pull request as ready for review November 10, 2023 17:46
@futa-ikeda futa-ikeda added this to the 23.14.0 milestone Nov 10, 2023
Copy link
Contributor

@futa-ikeda futa-ikeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐍

@adlius adlius merged commit 6fce871 into develop Nov 10, 2023
9 checks passed
bp-cos pushed a commit to bp-cos/ember-osf-web that referenced this pull request Jan 31, 2024
)

* [WIP] first stab at Boa addon ux

 * make boa modal findable
 * save WIP on dataset select
 * futa wisdom attained/accepted
 * add action; fetch parents properly
 * enabled addons enabled
 * cleanups; fix closemodal

* Add mirage support for BoA files

* Type updates

* authenticate addon endpoint request

* Add a bit of error handling to mirage

* Change logic to populate a node addons

* Disable submit to boa if no dataset selected

* Add qp to boa upload link

* Add placeholder message to dataset select

* Update toast messages

* CR feedback

* Boa bugs (CenterForOpenScience#2047)

* Add file size to boa request

* Allow checked out boa file to be submitted

* Use sizeInt

* Circumvent promise-induced bugs (CenterForOpenScience#2049)

---------

Co-authored-by: Fitz Elliott <fitz@cos.io>
Co-authored-by: Futa Ikeda <futa.ikeda@gmail.com>
Co-authored-by: futa-ikeda <51409893+futa-ikeda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants