Link to reports updates #2302
Merged
Link to reports updates #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaxelb
approved these changes
Aug 30, 2024
| @@ -9,7 +9,8 @@ | |||
| <OsfLink | |||
| data-test-link-to-reports-archive | |||
| data-analytics-name='Link to archived reports' | |||
| local-class='download-button' | |||
| @target='_blank' | |||
There was a problem hiding this comment.
hm, was about to say this should be target='_blank' (no @) but i see osf-link has its own target arg, in addition to passing thru ...attributes... so this is fine, but something i'd suggest changing about osf-link if it's ever revisited
futa-ikeda
merged commit 1ef837e
into
CenterForOpenScience:feature/insti-dash-improv
9 checks passed
Johnetordoff
pushed a commit
to Johnetordoff/ember-osf-web
that referenced
this pull request
Aug 30, 2024
…ForOpenScience/ember-osf-web into sort-users-for-inst-dashboard * 'feature/insti-dash-improv' of https://github.com/CenterForOpenScience/ember-osf-web: Link to reports updates (CenterForOpenScience#2302)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Summary of Changes
@fakeButtontoOsfLinkto easily make a link look like a button (which maybe isn't a pattern we want to encourage, but at least now it's DRY when we do it 😬 )Screenshot(s)
Side Effects
QA Notes