-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-6434] Show/hide file upload page on preprint submit workflow #2422
[ENG-6434] Show/hide file upload page on preprint submit workflow #2422
Conversation
this.isEditFlow = true; | ||
if (this.args.preprint.reviewsState === ReviewsState.REJECTED) { | ||
this.displayFileUploadStep = true; | ||
} else { | ||
this.displayFileUploadStep = false; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this component is invoked in the "Edit an existing preprint" workflow (this.args.preprint
being truthy in line 68), this bit of logic will be triggered. If the preprint that is passed in has reviews_state: 'rejected'
, the File upload step will be shown, otherwise the File upload step will be skipped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎆
In addition, appreciate the intuitive design of our preprint state machine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hooray for tests!
47ea434
into
CenterForOpenScience:feature/preprints-doi-versioning
Todo
Purpose
Summary of Changes
displayFileUploadStep
that controls whether or not the file upload step is shownScreenshot(s)
Create new preprint workflow showing the file upload step
Edit and resubmit workflow showing the file upload step
Editing an existing preprint no longer showing the file upload step
Side Effects
QA Notes