Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-6803] Preprint-doi select dropdown should have current version selected by default #2448

Merged
merged 1 commit into from
Jan 2, 2025
Merged

[ENG-6803] Preprint-doi select dropdown should have current version selected by default #2448

merged 1 commit into from
Jan 2, 2025

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Jan 2, 2025 •
edited by jira bot
Loading

Purpose

  • Indicate currently viewed version in the preprint DOI selection dropdown

Summary of Changes

  • Add a currentVersion param to the preprint-doi component
    • Have this version be the selected one by default
    • Add bold font style to current version

Screenshot(s)

  • When viewing version 2 out of 3 possible versions (note the _v2 in the URL)
    image
  • Upon opening dropdown, you can see that version2 is the currently viewed version
    image

Side Effects

QA Notes

cslzchen
cslzchen approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and verified locally 🎆

@futa-ikeda futa-ikeda merged commit b99fe9f into CenterForOpenScience:feature/preprints-doi-versioning Jan 2, 2025
9 checks passed
@futa-ikeda futa-ikeda deleted the current-preprint-doi branch January 2, 2025 16:30
@futa-ikeda futa-ikeda added this to the 25.03.0 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjgeiger brianjgeiger brianjgeiger approved these changes

@cslzchen cslzchen cslzchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
25.03.0
Development

Successfully merging this pull request may close these issues.
3 participants
@futa-ikeda @cslzchen @brianjgeiger