Use proper key for DOI field download #2455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
futa-ikeda
merged commit 11576cc
into
CenterForOpenScience:feature/share-download-integration
9 checks passed
futa-ikeda
added a commit
that referenced
this pull request
Jan 6, 2025
* [ENG-6823] Explicitly list columns for SHARE download (#2450) - Ticket: [ENG-6823] - Feature flag: n/a ## Purpose - Tell SHARE what information to download when downloading institutional dashboard data ## Summary of Changes - Add a new `propertyPathKey` property to the object-list columns - this is used to tell SHARE the format of each column - Remove `sortKey` property from column, and replace it with `isSortable` boolean property since `sortKey` is the same as `propertyPathKey` * Use proper key for DOI field download (#2455)
adlius
pushed a commit
that referenced
this pull request
Jan 6, 2025
* [ENG-6823] Explicitly list columns for SHARE download (#2450) - Ticket: [ENG-6823] - Feature flag: n/a ## Purpose - Tell SHARE what information to download when downloading institutional dashboard data ## Summary of Changes - Add a new `propertyPathKey` property to the object-list columns - this is used to tell SHARE the format of each column - Remove `sortKey` property from column, and replace it with `isSortable` boolean property since `sortKey` is the same as `propertyPathKey` * Use proper key for DOI field download (#2455)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Summary of Changes
sameAskey instead ofresourceIdentifierScreenshot(s)
Side Effects
QA Notes