Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-6814] Show toast message on 409 error #2456

Merged
merged 3 commits into from
Jan 6, 2025
Merged

[ENG-6814] Show toast message on 409 error #2456

merged 3 commits into from
Jan 6, 2025

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Jan 3, 2025 •
edited
Loading

Purpose

  • Show helpful toast message if the request to create a new version returns a 409 error

Summary of Changes

  • Fix logic for how to display toast error
  • Update template so the "Create new version" button is disabled when the task is running
  • Update page-not-found reroute logic to be more robust

Screenshot(s)

  • Disabled "Create new version" button
    image
  • Toast error message
    image

Side Effects

QA Notes

cslzchen
cslzchen approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally 🎆

Screen.Recording.2025-01-06.at.11.05.11.mov

@futa-ikeda futa-ikeda merged commit e7f9369 into CenterForOpenScience:feature/preprints-doi-versioning Jan 6, 2025
9 checks passed
@futa-ikeda futa-ikeda deleted the 409-toast branch January 6, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjgeiger brianjgeiger brianjgeiger approved these changes

@cslzchen cslzchen cslzchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@futa-ikeda @cslzchen @brianjgeiger