[ENG-6815][ENG-6843] Update condition to show edit button #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjgeiger
approved these changes
Jan 9, 2025
| @@ -78,8 +78,7 @@ module('Acceptance | preprints | detail', hooks => { | |||
| await visit('/preprints/osf/test'); | |||
|
|
|||
| // Check edit and new version buttons | |||
| assert.dom('[data-test-edit-preprint-button]').exists('Edit button is displayed'); | |||
| assert.dom('[data-test-edit-preprint-button]').containsText('Edit', 'Edit button text is correct'); | |||
| assert.dom('[data-test-edit-preprint-button]').doesNotExist('Edit button is not displayed for prior versions'); | |||
There was a problem hiding this comment.
This seems like a good opportunity to add tests for the other conditions this ticket covers.
cslzchen
requested changes
Jan 9, 2025
futa-ikeda
changed the title
futa-ikeda
merged commit 9366206
into
CenterForOpenScience:feature/preprints-doi-versioning
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Summary of Changes
Screenshot(s)
Side Effects
QA Notes