Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-6822] [ENG-6871] Fix bug where preprint status banner does not update #2465

Merged
merged 1 commit into from
Jan 10, 2025
Merged

[ENG-6822] [ENG-6871] Fix bug where preprint status banner does not update #2465

merged 1 commit into from
Jan 10, 2025

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Jan 10, 2025 •
edited by jira bot
Loading

Purpose

  • Fix an issue where the preprint status banner doesn't update when selecting a different version

Summary of Changes

  • Refactor status banner component to use arguments instead of a cached arg reference

Screenshot(s)

Side Effects

QA Notes

cslzchen
cslzchen approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix verified locally 🐛 ⚔️

@futa-ikeda futa-ikeda merged commit 51f651b into CenterForOpenScience:feature/preprints-doi-versioning Jan 10, 2025
9 checks passed
@futa-ikeda futa-ikeda deleted the update-status-banner branch January 10, 2025 19:21
@futa-ikeda futa-ikeda added this to the 25.03.0 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjgeiger brianjgeiger brianjgeiger approved these changes

@cslzchen cslzchen cslzchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
25.03.0
Development

Successfully merging this pull request may close these issues.
3 participants
@futa-ikeda @cslzchen @brianjgeiger