[ENG-5882] Added new context to the Registration Draft Metadata page #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12718433644Details
💛 - Coveralls |
brianjgeiger
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Looks good to me. Quick question for @futa-ikeda: Are there more semantic tags you know of for the descriptive text to be put into, or is this good for accessibility?
futa-ikeda
reviewed
Jan 13, 2025
futa-ikeda
approved these changes
Jan 13, 2025
bp-cos
merged commit 6a593c0
into
CenterForOpenScience:feature/b-and-i-25-01
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently since the registration metadata page was last updated to now, some formatter has been added to the repo which has caused my changes to this PR than expected.
Purpose
Add additional context to the Registration Draft Metadata page.
Summary of Changes
Add various new sentences to the en-us.yml file.
Add new "paragraph" elements to the draft/metadata/template.hbs file
Screenshot(s)
Side Effects
None that I can foresee or experienced while testing locally.
QA Notes
Please review content for accuracy.