Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement bug fix and account for permissions when accessing preprint requests #2485

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Jan 21, 2025

  • Ticket: []
  • Feature flag: n/a

Purpose

  • Reimplement this PR but account for the fact that only admins have access to a preprint's requests

Summary of Changes

  • Reimplement aforementioned PR but check that user has admin permission before fetching requests as only admins have access to a preprint's requests endpoint

Screenshot(s)

Side Effects

QA Notes

@futa-ikeda futa-ikeda changed the title Reimplement bug fix, but this time better (maybe) Reimplement bug fix and account for permissions when accessing preprint requests Jan 21, 2025
Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally 🌟

@futa-ikeda futa-ikeda merged commit df98061 into CenterForOpenScience:feature/preprints-doi-versioning Jan 21, 2025
9 checks passed
@futa-ikeda futa-ikeda deleted the reimplement-permissions-bug branch January 21, 2025 17:37
@futa-ikeda futa-ikeda added this to the 25.03.0 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants